tabindex parent bug fix for edge #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agirton
added
the
issue/bug-confirmed
|
Hi @George-A-Payne, besides Edge what browsers have you tested this in? Just want to make sure that this doesn't cause any regressions in any other browser when navigating with the tab key. |
|
Hi @agirton, |
|
Awesome. Thank you! |
|
Hi @George-A-Payne do you mind rebasing on top of master? Want to make sure all the tests pass before merging. |
George-A-Payne
force-pushed
the
edge-tabindex-bugfix
branch
from
2cbc7fc
to
2da6ff6
Compare
|
Thanks for this @George-A-Payne! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in Edge where if a parent of the select has a tabindex, you are unable to use the scrollbar within the select.
Within handleInputBlur, document.activeElement becomes the parent with tabindex, and fails the if().
To reproduce:
Add tabIndex={-1} to .section on this line of the examples. Open the example in Edge and observe the inability to scroll using the scrollbar.
This pull request adds tabindex={-1} to .Select-menu to prevent the parent from stealing the activeElement, and allows you to scroll.