-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removeSelected prop (round 2), for optionally keeping selected values in dropdown #1891
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fc6c47d
removeSelected toggle and examples
d67698e
.is-selected class bugfix for 'value' objects that don't have exactly…
783d9b9
Value should be checked against props.valueKey, not the entire object…
db856d3
Re-apply bugfixes in 655b9ee74bdb93e240b33af67c8fd936a27e5eda and 936…
dherran-hn 70c198c
Rename state.remove ==> state.removeSelected
banderson 1059b23
Restore removeSelected defaultValue
banderson 6558b1e
Remove findIndex polyfill
banderson 878b880
Add tests for removeSelected
banderson 3d88a77
Add note to docs about removeSelected prop
banderson 3779f38
Test coverage for toggling values in multi-select
banderson a6992e8
Don't need to reset onChange spy
banderson 7cd2237
Merge branch 'master' into remove-selected
gwyneplaine bdf7c8e
Update Select.js
gwyneplaine a7441cd
Update README.md
gwyneplaine 301a1a7
Update Select.js
gwyneplaine 9096af5
Update Select-test.js
gwyneplaine 41378ff
Merge branch 'master' into remove-selected
JedWatson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@banderson just a minor nit: should this be "If you want them to remain in the list, set
removeSelected={false}
"?