strip proptypes in production build (fixes #1882)

[jochenberger]

File size changes:

react-select.es.js: 82822 -> 82970
react-select.js: 84232 -> 84380
react-select.min.js: 43966 -> 41700

See also #1876.

[coveralls]

Coverage increased (+0.06%) to 92.056% when pulling fb33957 on jochenberger:strip-proptypes-in-production into 49b12b0 on JedWatson:master.

[jochenberger]

I guess we need to replace 'process.env.NODE_ENV' in the other two bundles too. But I'm not sure what we should replace it with in the es6 build.

[jochenberger]

And what should happen to lib/*.js? With this PR merged, they would contain the if (process.env.NODE_ENV !== 'production')wrappers. Are those files always used in a Node environment?
Maybe we should rather just add the https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types plugin to the .min.js build.

[coveralls]

Coverage increased (+0.06%) to 92.056% when pulling a6b023a on jochenberger:strip-proptypes-in-production into 49b12b0 on JedWatson:master.

[agirton]

Hi @jochenberger thank you for the PR, instead of putting the propTypes behind a flag, we could probably just use babel-plugin-transform-react-remove-prop-types. This would make it much cleaner. Thoughts?

[JedWatson]

we could probably just use babel-plugin-transform-react-remove-prop-types

yes please 🙂

[jochenberger]

I'm not so sure. Don't we want to have the checks in the src and lib files? I don't do node apps myself, but I imagine that people who do want the propTypes checks removed in production. If we only remove them in the bundles via babel-plugin-transform-react-remove-prop-types, they will always end up with the propTypes checks. However, if the if (process.env.NODE_ENV !== 'production') are present in the src and lib files, they will also effect the users' apps/bundles. Unless they use babel-plugin-transform-react-remove-prop-types too. I don't really know what's the best practice here, since I don't have much experience with node.
What do others do? react-router uses babel-plugin-transform-react-remove-prop-types for instance.

[JedWatson]

I think that it's not safe to have if (process.env.NODE_ENV !== 'production') anywhere other than in src. We can't guarantee anything about the environment the code may be run in now or in the future, which doing so breaks.

I don't think there's any concern having proptypes in place in a node environment, if the consumer requires the lib entry. React ignores proptypes in production anyway so this is only an optimisation for client-side package size.

Given the consistency of other major packages using babel-plugin-transform-react-remove-prop-types I think that's the way to go, and let's not introduce environment specific code in our source that we don't need to (I'm happy to follow react-router's configuration for this in terms of which builds to apply the plugin to)

[JedWatson]

Please update to use babel-plugin-transform-react-remove-prop-types

[jochenberger]

Done. Now the only file size change is react-select.min.js: 44246 -> 41927.

[coveralls]

Coverage remained the same at 92.344% when pulling 5da115a on jochenberger:strip-proptypes-in-production into eb2dfba on JedWatson:master.

[JedWatson]

Neat, thanks @jochenberger!