Support Webpack 2, Webpack 3, rollup. #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current LTS versions of Webpack and Node honor the standardized `module` field in the `package.json`. As I am using webpack 3 and was confused when it wasn't resolving your awesome optimized dist builds, I decided to PR it for y'all.
|
Thanks for picking that up @mschnee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current LTS versions of Webpack and Node honor the standardized
modulefield in thepackage.json. As I am using webpack 3 and was confused when it wasn't resolving your awesome optimized dist builds, I decided to PR the fix for y'all (and leave the oldjsnext:mainas there are plenty of systems that still use it)