Add aria-labels to Options #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is my first time contributing to open source, so please let me know if there is anything you would like me to modify/change with this PR. Thanks!
I was working on accessibility/screen reader related fixes and a bug came up when testing with JAWS 18 and IE11 (on Win7). When navigating through the options, JAWS will only read "Link" for each option, but will not narrate the option label correctly to the user. For someone using a screen reader, this is a problem because they will have no idea what the options actually are. I added an aria-label to Options which will allow JAWS to correctly read the option.