New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keepCursorAtEnd prop for single value input #2176
Conversation
Hi, A lot of tests failed. Please fix it. Thanks. |
Will double check the tests, thanks for flagging. |
de1e986
to
b40c76f
Compare
b40c76f
to
edf5476
Compare
edf5476
to
3dc0448
Compare
3dc0448
to
c89c575
Compare
This will allow single value input to position the cursor at the end of the input string instead of at the beginning.
c89c575
to
52bfb5f
Compare
@yuri-sakharov Fixed the test issues. |
Any Updates on merging this PR @xiaolin @yuri-sakharov |
@walifaizy I did't have permissions for this |
Cool @yuri-sakharov thanks for the reply, Do you have any idea who is going to merge this PR |
@walifaizy I think owner, collaborators. |
thanks @yuri-sakharov |
thanks @yuri-sakharov , would this to be merged in. |
@xiaolin @yuri-sakharov @cdm430 @walifaizy @coveralls Any Idea when this PR will be merged in? or if there is a work around we can do on our end when using the AutoComplete Library component? |
Any update on this? |
Oh, goodness, so many people want it to be merged. I also badly need this future. |
will not this patch be merged into the project? |
+1 |
Maybe this is minor, but I disagree with the prop name. The behavior itself is dependent on the input being |
What's up? |
EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance! |
Greetings @xiaolin and thank you for the submission. Also apologies for the long delay in a response. This PR is a bit out of date with the existing implementation as it was developed against v1. I cannot say whether it would be a good fit when it was first proposed, but much of the library has changed as it's approaching yet another major release and it seems that these changes would no longer be a fit especially since This PR will be closed, though the team and the community appreciate any and all efforts to improve react-select. |
This will allow single value input to position the cursor at the end of the input string instead of at the beginning. #164 #1874