Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepCursorAtEnd prop for single value input #2176

Closed
wants to merge 2 commits into from

Conversation

xiaolin
Copy link

@xiaolin xiaolin commented Nov 27, 2017

This will allow single value input to position the cursor at the end of the input string instead of at the beginning. #164 #1874

@yuri-sakharov
Copy link
Contributor

Hi,

A lot of tests failed. Please fix it.

Thanks.

@xiaolin
Copy link
Author

xiaolin commented Nov 28, 2017

Will double check the tests, thanks for flagging.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 92.993% when pulling b40c76f on xiaolin:cursor-feature into 0d0ccd3 on JedWatson:master.

@coveralls
Copy link

coveralls commented Nov 28, 2017

Coverage Status

Coverage decreased (-0.08%) to 93.285% when pulling edf5476 on xiaolin:cursor-feature into 0d0ccd3 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 93.285% when pulling 3dc0448 on xiaolin:cursor-feature into 0d0ccd3 on JedWatson:master.

This will allow single value input to position the cursor
at the end of the input string instead of at the beginning.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.431% when pulling 52bfb5f on xiaolin:cursor-feature into 0d0ccd3 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.431% when pulling 52bfb5f on xiaolin:cursor-feature into 0d0ccd3 on JedWatson:master.

@xiaolin
Copy link
Author

xiaolin commented Nov 28, 2017

@yuri-sakharov Fixed the test issues.

@walifaizy
Copy link

Any Updates on merging this PR @xiaolin @yuri-sakharov

@yuri-sakharov
Copy link
Contributor

@walifaizy I did't have permissions for this

@walifaizy
Copy link

Cool @yuri-sakharov thanks for the reply, Do you have any idea who is going to merge this PR

@yuri-sakharov
Copy link
Contributor

@walifaizy I think owner, collaborators.

@walifaizy
Copy link

thanks @yuri-sakharov

@cdm430
Copy link

cdm430 commented Feb 12, 2018

thanks @yuri-sakharov , would this to be merged in.

@Berrios
Copy link

Berrios commented Nov 26, 2018

@xiaolin @yuri-sakharov @cdm430 @walifaizy @coveralls Any Idea when this PR will be merged in? or if there is a work around we can do on our end when using the AutoComplete Library component?

@noisyscanner
Copy link

Any update on this?

@gorioli
Copy link

gorioli commented Jun 17, 2019

Oh, goodness, so many people want it to be merged. I also badly need this future.

@tavareshenrique
Copy link
Contributor

will not this patch be merged into the project?

@Veroer
Copy link

Veroer commented Jan 3, 2020

+1

@bladey bladey removed the feature label May 26, 2020
@bladey bladey added enhancement pr/needs-review PRs that need to be reviewed to determine outcome pr/priority PRs that should be addressed sooner rather than later and removed deprecated labels Jun 4, 2020
@bladey bladey linked an issue Jun 5, 2020 that may be closed by this pull request
@bladey bladey added pr/enhancement PRs that are specifically enhancing the project and removed category/enhancement labels Jun 24, 2020
@ebonow
Copy link
Collaborator

ebonow commented Jul 14, 2020

Maybe this is minor, but I disagree with the prop name.

The behavior itself is dependent on the input being editable rather than keeping the cursor at the end. I too would like to see this behavior and perhaps even set as default. In the meanwhile, here is an implementation that allows editing and selecting of text.

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome and removed pr/needs-review PRs that need to be reviewed to determine outcome labels Aug 24, 2020
@mindmind
Copy link

What's up?

@Methuselah96
Copy link
Collaborator

Methuselah96 commented Nov 14, 2020

I've started a fork of react-select. Feel free to resubmit this PR on the fork and we can get it merged and released.

EDIT: 🎉 I've archived the fork now that we've got some momentum in this repo and Jed is involved again. Sorry for the disturbance!

@ebonow
Copy link
Collaborator

ebonow commented Jan 16, 2021

Greetings @xiaolin and thank you for the submission. Also apologies for the long delay in a response.

This PR is a bit out of date with the existing implementation as it was developed against v1. I cannot say whether it would be a good fit when it was first proposed, but much of the library has changed as it's approaching yet another major release and it seems that these changes would no longer be a fit especially since onBlurResetsInput was deprecated.

This PR will be closed, though the team and the community appreciate any and all efforts to improve react-select.

@ebonow ebonow closed this Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/enhancement PRs that are specifically enhancing the project pr/needs-review PRs that need to be reviewed to determine outcome pr/priority PRs that should be addressed sooner rather than later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text cursor location