Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression fix for single select with onSelectResetsInput=false #2226

Merged
merged 9 commits into from
Dec 19, 2017
Merged

Regression fix for single select with onSelectResetsInput=false #2226

merged 9 commits into from
Dec 19, 2017

Conversation

yuri-sakharov
Copy link
Contributor

@yuri-sakharov yuri-sakharov commented Dec 16, 2017

Hi,
We got bug on single select with onSelectResetsInput=false after #2205
The bug doesn't show selected value when inputValue not empty. You can reproduce it after add onSelectResetsInput=false to single (multi=false or not set) Select.
The bug example:
bug
And fix:
fix

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 93.803% when pulling d933d19 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.944% when pulling b826140 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.944% when pulling b826140 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.944% when pulling ae26bf8 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 94.076% when pulling 2f6f2dc on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@yuri-sakharov
Copy link
Contributor Author

Last commit was removed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.944% when pulling 6c15260 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.944% when pulling 8de1ef6 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.944% when pulling d526036 on yuri-sakharov:fix/on-select-resets-input-for-single into a065ad4 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for catching this regression, @yuri-sakharov!

@JedWatson JedWatson merged commit d2a3afd into JedWatson:master Dec 19, 2017
@yuri-sakharov yuri-sakharov deleted the fix/on-select-resets-input-for-single branch December 19, 2017 07:15
@yuri-sakharov
Copy link
Contributor Author

You are welcome

@aryeguy
Copy link

aryeguy commented Dec 24, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants