Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering with arrowRenderer and no autosize. #2276

Merged
merged 1 commit into from
Jan 13, 2018

Conversation

harrykao
Copy link

The container for the input element lacked display: inline-block,
which is present on both the AutosizeInput component and the disabled
version of the input component.

This should fix #2082 and #2202.

The container for the input element lacked "display: inline-block",
which is present on both the AutosizeInput component and the disabled
version of the component.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.973% when pulling d235dee on harrykao:input_inline_block into 851d94b on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for the fix @harrykao

@JedWatson JedWatson merged commit c64df28 into JedWatson:master Jan 13, 2018
@harrykao harrykao deleted the input_inline_block branch January 13, 2018 05:19
@natefoundry
Copy link

This commit may have unintentionally broken the width and vertical alignment of the hidden input field. I have autosize=false and if I type a lot of characters in the text box it cuts off before reaching the end of the total width of the text box (tested on Chrome).

Adding the following scss fixed the issue for me:

  /* Fixes issue with input width and position introduced by commit: d235dee2 */
  .Select-input {
    display: block !important;

    & > input {
      display: inline-block !important;
    }
  }

@glambert
Copy link

glambert commented Feb 20, 2018

@natefoundry I also got this issue, I will implement the fix you have proposed. Should that be opened as a PR, or it needs more testing?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Multi has broken with prop autosize=false
5 participants