Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Select v2 #2289

Merged
merged 775 commits into from
Jul 23, 2018
Merged
Show file tree
Hide file tree
Changes from 143 commits
Commits
Show all changes
775 commits
Select commit Hold shift + click to select a range
92f1037
v2.0.0-beta.1
JedWatson Apr 20, 2018
77aa268
Minor website tweaks
JedWatson Apr 20, 2018
c957801
Adding yarn.lock for netlify
JedWatson Apr 20, 2018
a54fbba
Updating yarn.lock
JedWatson Apr 20, 2018
6946eea
Export indicator icons for use in customizations
jesstelford Apr 20, 2018
eef3ac1
Updating travis script
JedWatson Apr 20, 2018
64ef10c
Merge pull request #2535 from jesstelford/patch-1
JedWatson Apr 20, 2018
e9872f7
Tweaking header on website
JedWatson Apr 20, 2018
5e91e18
Fixing a warning in the docs website
JedWatson Apr 20, 2018
2c84c0b
upgrade pretty-proptypes and codesandboxer for fun new features
Noviny Apr 23, 2018
e81145b
upgrade guide now has filter and order options for all props
Noviny Apr 23, 2018
3001f29
remove use of Fragment in Select.js
gwyneplaine Apr 23, 2018
0ea7b19
Merge pull request #2544 from JedWatson/v2-remove-fragment
JedWatson Apr 23, 2018
8f59fea
Menu should be wrapped in a div, not a span ref #2544
JedWatson Apr 23, 2018
d636a03
Merge pull request #2543 from Noviny/bcon/update-guide-sort-and-filter
JedWatson Apr 23, 2018
f079c40
Replacing glam with emotion
JedWatson Apr 23, 2018
bf200ac
Fixing issues with the umd index
JedWatson Apr 23, 2018
1c57787
Adding bundlesize reporter to build process
JedWatson Apr 23, 2018
dfb885e
Add ability to change input color
lesha1201 Apr 23, 2018
d877441
Removing (now) unnecessary white space from flex styles
JedWatson Apr 23, 2018
ec76e1d
Flow should ignore dist/
JedWatson Apr 23, 2018
93bf2b9
Fixing snapshots after css change
JedWatson Apr 24, 2018
b047767
added universal/ssr rendering support
falconmick Apr 24, 2018
3fa147d
Replacing glam with emotion
JedWatson Apr 23, 2018
839be30
Removing (now) unnecessary white space from flex styles
JedWatson Apr 23, 2018
6944231
Fixing snapshots after css change
JedWatson Apr 24, 2018
3f08b19
Merge branch 'v2' of https://github.com/lesha1201/react-select into l…
gwyneplaine Apr 24, 2018
7a1e9dd
update jest snapshots
gwyneplaine Apr 24, 2018
b48b8ed
rerun cypress
gwyneplaine Apr 24, 2018
f28c53b
Merge branch 'v2-use-emotion' of github.com:JedWatson/react-select in…
JedWatson Apr 25, 2018
dd107fa
Moving dependencies to devDependencies
JedWatson Apr 25, 2018
aef6cd3
Merge pull request #2548 from falconmick/v2
JedWatson Apr 25, 2018
722a984
Merge pull request #2549 from JedWatson/lesha1201-v2
JedWatson Apr 25, 2018
453d4db
Fixing browserslistrc, thanks @jamiebuilds
JedWatson Apr 25, 2018
b199642
Merge branch 'v2' into v2-use-emotion
JedWatson Apr 25, 2018
3fa5f68
Add CircleCI config
JedWatson Apr 25, 2018
65872e6
Merge pull request #2547 from JedWatson/v2-use-emotion
JedWatson Apr 25, 2018
8a61132
Updating TODO
JedWatson Apr 25, 2018
b52bb4d
v2.0.0-beta.2
JedWatson Apr 25, 2018
4496200
fix group component in experimental
gwyneplaine Apr 25, 2018
c6ef219
Merge branch 'v2' into v2-setup-circleci
JedWatson Apr 26, 2018
503863b
Adding changes from #2559
JedWatson Apr 26, 2018
8df83aa
Updating e2e script
JedWatson Apr 26, 2018
6348950
Updating e2e task thanks to @willmendesneto
JedWatson Apr 27, 2018
6a7bb50
Merge pull request #2557 from JedWatson/v2-setup-circleci
JedWatson Apr 27, 2018
f3d937c
Updating dependencies
JedWatson Apr 27, 2018
a01fd94
Simplify flow distribution
TrySound Apr 30, 2018
91e6a73
added documentation on how to SSR
falconmick May 4, 2018
58feef3
Merge remote-tracking branch 'jed/v2' into v2
falconmick May 4, 2018
82f654c
Fixing a bug where nextProps is not always used when building menu op…
JedWatson May 4, 2018
434008e
Ensuring inputValue is always a string in buildMenuOptions
JedWatson May 4, 2018
124dad0
initial commit of multi-value keyboard functionality
gwyneplaine Apr 30, 2018
ba16de9
added inputValue checks to multivalue keyboard input handle
gwyneplaine May 2, 2018
f190dec
added onValueClick prop
gwyneplaine May 4, 2018
8f9312f
nullify focus value on clear, add onValueClick trigger to space key p…
gwyneplaine May 4, 2018
3ba8ab5
onValueClick implementation for Multi and Single Value components
gwyneplaine May 7, 2018
baa578c
refactor focusedValue detection logic in Select.js
gwyneplaine May 7, 2018
bee7510
remove onValueClick implementation;
gwyneplaine May 7, 2018
f348c58
Adding --isDisabled classname to Option
eemeli May 7, 2018
6743fab
fix control showing scroll bar, fix overflowing options in menu
gwyneplaine May 8, 2018
60b3304
added flex-basis to menuList component to fix overflow issue in ie11
gwyneplaine May 9, 2018
5a94db1
trigger CI rerun
gwyneplaine May 9, 2018
9401a3e
Updating CircleCI docker container for cypress
JedWatson May 9, 2018
869ea67
Merge pull request #2593 from JedWatson/v2-ie11-fixes
JedWatson May 9, 2018
13b62f4
Merge pull request #2589 from eemeli/v2-add-option-disabled-classname
JedWatson May 9, 2018
f530430
Merge pull request #2585 from falconmick/v2
JedWatson May 9, 2018
b3bfb67
Merge pull request #2564 from JedWatson/v2-fix-experimental
JedWatson May 9, 2018
2371278
Moving SSR documentation to the Advanced guide
JedWatson May 9, 2018
766e6d9
initial commit of multi-value keyboard functionality
gwyneplaine Apr 30, 2018
addff0e
added inputValue checks to multivalue keyboard input handle
gwyneplaine May 2, 2018
9168cb1
added onValueClick prop
gwyneplaine May 4, 2018
1cb3df2
nullify focus value on clear, add onValueClick trigger to space key p…
gwyneplaine May 4, 2018
25e9894
onValueClick implementation for Multi and Single Value components
gwyneplaine May 7, 2018
0786771
refactor focusedValue detection logic in Select.js
gwyneplaine May 7, 2018
d29b342
remove onValueClick implementation;
gwyneplaine May 7, 2018
f499b4d
removed onValueClick from basicMulti example
gwyneplaine May 9, 2018
6b79efe
Cleaning up focusValue implementation
JedWatson May 10, 2018
31d4236
Fixing the getNextFocusedValue method
JedWatson May 10, 2018
6759999
Merge branch 'v2-multi-value-keyboard' of github.com:JedWatson/react-…
JedWatson May 10, 2018
42a334b
Ensuring the focused option is cleared when an option is selected
JedWatson May 10, 2018
5ddef45
Fixing a bug where backspaceRemovesValue breaks removing focused options
JedWatson May 10, 2018
30afdd5
Merge pull request #2584 from JedWatson/v2-multi-value-keyboard
JedWatson May 10, 2018
d545228
Removing console.log from examples
JedWatson May 10, 2018
bac99e8
Remove maxValueHeight prop
JedWatson May 10, 2018
d7c4233
Updating snapshots
JedWatson May 10, 2018
b737aa5
Removing remaining code linked to the maxValueHeight feature
JedWatson May 10, 2018
1f0bdc1
Updating snapshots
JedWatson May 10, 2018
f899cfe
Merge pull request #2595 from JedWatson/v2-remove-max-value-height
JedWatson May 10, 2018
0a77534
remove flex from menu to address ie11 concerns
gwyneplaine May 10, 2018
60910df
Merge pull request #2596 from JedWatson/v2-remove-menu-flex
JedWatson May 10, 2018
84a3007
Ensuring the input has focus when the menu opens, fixes #2591
JedWatson May 10, 2018
4e11baf
Merge pull request #2576 from TrySound/simple-flow-distribution
JedWatson May 10, 2018
8d97e3e
Hardening SSR compatibility, fixes #2555
JedWatson May 10, 2018
9009fff
update innerRef key in innerProps to be ref for better developer expe…
gwyneplaine May 14, 2018
cf2557d
refactor cx implementation to accomodate new className construction a…
gwyneplaine May 14, 2018
7ffc0e0
update snapshots to account for change from referencing primitive com…
gwyneplaine May 14, 2018
a1cdcf2
remove reference to input primitive in dummyinput file
gwyneplaine May 14, 2018
ab820ec
prep changelog for beta.3 release
gwyneplaine May 14, 2018
649d1fe
Update HISTORY.md
gwyneplaine May 14, 2018
b6e0045
Merge pull request #2602 from JedWatson/v2-innerRef-to-ref
JedWatson May 14, 2018
f2ab6ad
add classNamesPrefix, add deprecation warning for old className funct…
gwyneplaine May 14, 2018
813bb6d
fix snapshot
gwyneplaine May 14, 2018
cd3662b
Merge branch 'v2' of github.com:JedWatson/react-select into v2
JedWatson May 14, 2018
bc75878
Exporting Async, AsyncCreatable and Creatable in main bundle
JedWatson May 14, 2018
928f6d2
Merge pull request #2605 from JedWatson/v2-classNamePrefix
JedWatson May 14, 2018
899fa6e
Merge branch 'v2' of github.com:JedWatson/react-select into v2
JedWatson May 14, 2018
ce9b37e
Update HISTORY.md
gwyneplaine May 14, 2018
138e1d7
Merge pull request #2603 from JedWatson/v2-update-history
JedWatson May 14, 2018
ec38802
Updating changelog for beta.3
JedWatson May 14, 2018
cf12555
v2.0.0-beta.3
JedWatson May 14, 2018
141fb84
remove flow-fix-me, resolve merge conflicts
gwyneplaine May 15, 2018
b3aeadc
Merge branch 'MikeLimeRocket-v2' into v2
gwyneplaine May 15, 2018
d96826b
fix DummyInput ref
gwyneplaine May 15, 2018
dab8145
update changelog
gwyneplaine May 15, 2018
eefdfe9
fix custom indicator separator example
gwyneplaine May 15, 2018
3c68032
v2.0.0-beta.4
gwyneplaine May 15, 2018
004d9d8
Add brief class name explanation to Styles docs
fozcodes May 16, 2018
ca7b5fc
Fix spelling of "IndicatorSeparator"
robertcoopercode May 17, 2018
1e99d6c
fix(Select): use getOptionValue to compare values when filtering sele…
May 17, 2018
9e96c2f
add popout example to advanced docs;
jossmac May 18, 2018
ab600f0
update snapshots
jossmac May 18, 2018
1aa09e9
Merge pull request #2623 from JedWatson/popout-select
JedWatson May 18, 2018
2853384
prop name change
jossmac May 18, 2018
9e4158f
Merge pull request #2624 from JedWatson/prop-name-change
gwyneplaine May 18, 2018
51c9907
v2.0.0-beta.5
gwyneplaine May 18, 2018
abfd6d8
Fix Warning: Unknown prop `css` on <div> tag in div (created by Singl…
guigs May 18, 2018
95b1d2b
Merge pull request #2628 from guigs/patch-1
gwyneplaine May 21, 2018
575b495
Merge pull request #2615 from fozcodes/add_classname_info_to_styles_docs
gwyneplaine May 22, 2018
5e6672c
Merge branch 'v2' of https://github.com/JedWatson/react-select into v2
gwyneplaine May 22, 2018
cd03fdc
add removedValue to actionMeta
gwyneplaine May 22, 2018
f1bb484
Merge pull request #2637 from JedWatson/v2-give-removed-value
JedWatson May 23, 2018
9969101
update styles docs to do with className and classNamePrefix
gwyneplaine May 22, 2018
104e62e
Merge pull request #2632 from JedWatson/v2-update-className-docs
JedWatson May 23, 2018
f2b3df3
change internal component ref to innerRef to maintain compatibility w…
gwyneplaine May 22, 2018
cc7de65
fix snapshots and tests
gwyneplaine May 22, 2018
b21f595
Merge pull request #2631 from JedWatson/v2-revert-ref-to-innerRef
JedWatson May 23, 2018
e894af2
Merge pull request #2620 from robertcoopercode/patch-1
JedWatson May 23, 2018
94932a2
removed flex from menu and menuList
gwyneplaine May 23, 2018
eb7b2da
Merge branch 'v2' of https://github.com/JedWatson/react-select into v2
gwyneplaine May 23, 2018
87bf28a
Merge branch 'v2' into pr/2622
JedWatson May 23, 2018
7ed688d
Merge pull request #2622 from inv8der/use-getOptionValue-to-filter
JedWatson May 23, 2018
ada7379
Allow Creatable option first
iojichervo Apr 27, 2018
9f309e8
rename prop to createOptionPosition with a string value type instead …
gwyneplaine May 23, 2018
abe089b
Merge pull request #2638 from JedWatson/iojichervo-creatable-option-f…
gwyneplaine May 23, 2018
7f89f32
improve touch handling
jossmac May 23, 2018
b735c2d
Merge pull request #2639 from JedWatson/improve-touch-handling
gwyneplaine May 23, 2018
69ad427
v2.0.0-beta.6
gwyneplaine May 23, 2018
6202304
Upgrade package "flow-bin" to v0.72.0
May 22, 2018
61f3cba
Fix Flowtyping
May 23, 2018
76a727e
Re-render when defaultOptions changes
jesstelford May 28, 2018
af5d386
Example indentation fix
JuhQ Jun 7, 2018
732fb90
Change isOptionDisabled to have the same inputs as isOptionSelected
Jun 8, 2018
94df8a7
Merge pull request #2687 from JuhQ/patch-2
gwyneplaine Jun 12, 2018
e5f8388
Change type for indicator components be nullable
mike1808 Jun 14, 2018
3789000
Add meta to onChange when isMulti
Jun 18, 2018
cc3f1a1
Merge pull request #2646 from lunij/v2-flowtype-update
gwyneplaine Jun 19, 2018
efe2bfd
fix loadingDot not using emotions css fn to compile styles object, re…
gwyneplaine Jun 19, 2018
e1eb022
changing all emotionCss invocations to css(), changed styling functio…
gwyneplaine Jun 19, 2018
9a67cc8
added makeAnimated method, animated/index export default is now an em…
gwyneplaine Jun 19, 2018
56de1bb
[v2] fix className composition
nihgwu Jun 20, 2018
2728e40
Fix for #2716 - Missing type annotation for U.
himerus Jun 20, 2018
30dee63
Merge pull request #2732 from himerus/bug/2716-type-annotation
gwyneplaine Jun 21, 2018
22e0f2c
change onMenuScrollToTop and onMenuScrollToBottom as optional properties
mike1808 Jun 26, 2018
f9ddfa3
Fix typo in tst
JuhQ Jun 26, 2018
9b1cc2c
Merge pull request #2748 from teamable-software/v2-fix-select-prop-types
gwyneplaine Jun 27, 2018
5122376
fix default behaviour for hideSelectedOptions property
jossmac Jun 27, 2018
f84612d
update snapshots
jossmac Jun 27, 2018
9c5e84f
Merge pull request #2753 from JedWatson/v2-hide-selected-default
JedWatson Jun 27, 2018
3340908
Merge pull request #2717 from SimeonC/v2-multi-select-option-meta
JedWatson Jun 27, 2018
18e0620
Merge pull request #2749 from JuhQ/patch-3
JedWatson Jun 27, 2018
7342e07
Merge pull request #2723 from JedWatson/v2-fix-loading-dot-styles
JedWatson Jun 27, 2018
7409317
Merge pull request #2733 from nihgwu/neo/className
JedWatson Jun 27, 2018
e855b8d
Optimising applyPrefixToName
JedWatson Jun 27, 2018
a0adb34
Replacing .includes with .indexOf for IE11, fixes #2701
JedWatson Jun 27, 2018
91a7490
Don't render the menu when messages return null
JedWatson Jun 27, 2018
005470a
fix to export of animated/index to be non-breaking
gwyneplaine Jun 27, 2018
68a65c2
Merge pull request #2708 from teamable-software/v2-update-components-…
JedWatson Jun 27, 2018
76ef016
fix mobile scroll blocking
jossmac Jun 28, 2018
7424383
Merge pull request #2756 from JedWatson/fix-mobile-scroll-blocking
JedWatson Jun 29, 2018
d955def
Merge pull request #2754 from JedWatson/v2-hide-menu-with-null-message
JedWatson Jun 29, 2018
69abb3f
Pipe the onTouchEnd event down to MultiValueRemove's props
chuckbergeron Jun 29, 2018
dad61a2
export makeAnimated from src/index
gwyneplaine Jul 2, 2018
0aa496e
Merge pull request #2724 from JedWatson/v2-make-animated
gwyneplaine Jul 2, 2018
3a1ff97
Merge pull request #2762 from chuckbergeron/fix/multiValueRemove
gwyneplaine Jul 3, 2018
ab42d2d
remove unnecessary aria props from Input and Group components
gwyneplaine May 2, 2018
9455736
removed unnecessary aria attributes from Menu and Option
gwyneplaine May 2, 2018
b7a3534
remove allytext from loadingIndicator
gwyneplaine May 2, 2018
8bba325
aria hidden true on indicators and svgs
gwyneplaine May 2, 2018
774e979
clean up flow types LoadingIndicator class, add aria-hidden to passe…
gwyneplaine May 2, 2018
27a7d66
initial live-region implementation
gwyneplaine May 7, 2018
612dd62
accessibility wip, added focused options and inputvalue change announ…
gwyneplaine May 8, 2018
363d635
add utility methods for aria live region updates for option focus, se…
gwyneplaine May 8, 2018
7b5089d
removed instructions from menuIsOpen and moved to focusOption and foc…
gwyneplaine Jun 5, 2018
5ccccc3
react-aria-live implementation w aria-live-regions
gwyneplaine Jun 8, 2018
053edd7
add instructions and valueEvent functions for defining ariaLiveSelect…
gwyneplaine Jun 18, 2018
2b17ed4
added accessibility folder, added helper fucntions for aria messages …
gwyneplaine Jun 18, 2018
b064304
update cypress tests
gwyneplaine Jun 22, 2018
8b169af
added null checks for values passed into announceStatus
gwyneplaine Jun 22, 2018
8f5cb3a
update snapshots
gwyneplaine Jun 22, 2018
b8fc4c3
updated tests to reflect changes to accessibility implementation
gwyneplaine Jun 22, 2018
4f799ca
revert menuList innerProps removal for more consistent api
gwyneplaine Jul 3, 2018
3e066cb
optimise constructAriaLiveMssage function for readability
gwyneplaine Jul 3, 2018
b3fb7d7
Merge pull request #2581 from JedWatson/v2-live-region-implementation
gwyneplaine Jul 3, 2018
2c40499
beta.7 changelogs
gwyneplaine Jul 2, 2018
2240a48
update changelog
gwyneplaine Jul 2, 2018
b290b42
updates to history and yarnlock file
gwyneplaine Jul 3, 2018
f95f349
Merge pull request #2766 from JedWatson/v2-beta.7-changelogs
gwyneplaine Jul 3, 2018
322a097
specify file in path of imports for rollup build resolution
gwyneplaine Jul 3, 2018
22dff31
v2.0.0-beta.7
gwyneplaine Jul 3, 2018
22e7ae7
Pressing <Enter> in IME mode should not select a option
shamabe Jul 2, 2018
6733312
Add bullet re: ref name change
jossmac Jul 5, 2018
c40ea23
Merge pull request #2652 from jesstelford/patch-2
gwyneplaine Jul 11, 2018
f1cb4ee
Tidy up rollup config (#2788)
TrySound Jul 13, 2018
74864af
Prefer more descriptive esm word instead of es
TrySound May 23, 2018
8e83dff
Added new prop that allows menu to be automatically closed when the …
Jul 18, 2018
125d84a
apply memoize-one and react-fast-compare to components Cache in Selec…
gwyneplaine Jul 20, 2018
a3d8baa
Merge pull request #2814 from JedWatson/v2-components-cache
JedWatson Jul 21, 2018
1704201
Merge pull request #2767 from shamabe/fix-for-ime
JedWatson Jul 23, 2018
4ebdec8
v2 readme
gwyneplaine Jul 23, 2018
9b7829f
remove deprecation warning and backward compatibility logic
gwyneplaine Jul 23, 2018
e3d862a
Remove primitives and update MultiValue components
JedWatson Jul 23, 2018
930ea68
fix cypress test failure
gwyneplaine Jul 23, 2018
4b500d9
Merge pull request #2695 from SimeonC/v2-improve-isoptiondisabled
JedWatson Jul 23, 2018
3036c6c
Change filterOption from hard-coded prop to defaultProp
JedWatson Jul 23, 2018
dd033b1
Merge pull request #2821 from JedWatson/v2-remove-primitives
JedWatson Jul 23, 2018
033cba7
update snapshots
gwyneplaine Jul 23, 2018
8aebc03
Merge pull request #2809 from Vynlar/v2
JedWatson Jul 23, 2018
97d2760
Merge pull request #2818 from JedWatson/v2-readme
JedWatson Jul 23, 2018
08ef385
Merge pull request #2820 from JedWatson/v2-remove-dep-warn
JedWatson Jul 23, 2018
5f21735
remove invocation of null in defaultOptions to account for extract-re…
gwyneplaine Jul 23, 2018
4967ba1
Merge pull request #2822 from JedWatson/v2-default-async-filters
JedWatson Jul 23, 2018
c3d2e8a
change menuList to declare innerRef instead of nest it within innerProps
gwyneplaine Jul 23, 2018
75707e7
Control now declares innerRef outside of innerProps object
gwyneplaine Jul 23, 2018
cb15dbc
update innerRef of Option component to be independent of innerProps p…
gwyneplaine Jul 23, 2018
f36fed2
update snapshots
gwyneplaine Jul 23, 2018
7a3c5c4
update upgradeGuide with up to date information circa custom componen…
gwyneplaine Jul 23, 2018
f3e3932
update reference to plunkr to reference codesandbox in stead
gwyneplaine Jul 23, 2018
37b83fd
move ISSUE_TEMPLATE to .github/ISSUE_TEMPLATE
gwyneplaine Jul 23, 2018
20ceabc
Removing unused Travis config
JedWatson Jul 23, 2018
4cd69d5
Merge pull request #2825 from JedWatson/v2-update-issue-template
JedWatson Jul 23, 2018
cc095f8
Merge pull request #2824 from JedWatson/v2-redistribute-innerRef
JedWatson Jul 23, 2018
111f513
update contributing md
gwyneplaine Jul 23, 2018
7567283
Merge pull request #2641 from TrySound/es-to-esm
JedWatson Jul 23, 2018
5ac6876
Merge pull request #2826 from JedWatson/v2-update-contributing.md
JedWatson Jul 23, 2018
aa22e49
update changelog in prep for v2.0.0 release
gwyneplaine Jul 23, 2018
562c02b
Merge pull request #2828 from JedWatson/v2-release-changelog
JedWatson Jul 23, 2018
24f85f8
Merge branch 'master' into v2
gwyneplaine Jul 23, 2018
f85fe6d
inlining react-fast-compare to get around rollup configuration issues
gwyneplaine Jul 23, 2018
b455622
Readme improvements for v2
JedWatson Jul 23, 2018
8261f19
Merge branch 'v2' of github.com:JedWatson/react-select into v2
JedWatson Jul 23, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions .TODO.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
# Order of focus:

* [ ] Lock scrolling on Menu (enable with prop)
* [ ] Pass more (and consistent?) props and state from Select to Components
* [x] Fix issue with how the mouse hover interacts with keyboard scrolling
* [x] Ability to customise built-in strings
* [ ] Tags mode (Creatable)
* [-] Make inputValue a controllable prop
* [ ] Make menuIsOpen a controllable prop
* [ ] Render menu always open | as a dropdown | not at all
* [ ] Handle changing of isDisabled prop
* [ ] Virtualisation
* [ ] Documentation
* [ ] * Props
* [ ] * Customisation
* [ ] Upgrade Guide from v1 -> v2
* [ ] Cleanup

---

# Review:

* [ ] Make sure all on{Event} props that make sense are implemented
* [ ] Check old props that may need to be brought forward:
* [ ] * `autoBlur` (was for mobile -- still necessary?)
* [ ] * `autosize` (not sure why this needs to be supported?)
* [ ] * `backspaceToRemoveMessage`
* [ ] * `className` (for container)
* [ ] * `clearable` (can just provide no component)
* [ ] * `clearAllText` / `clearValueText` (can override component?)
* [ ] * `id` (for container) / `inputId`
* [ ] * `onBlurResetsInput` / `onCloseResetsInput` / `onSelectResetsInput`
* [ ] * `onClose` / `onOpen`
* [ ] * `onMenuScrollToBottom`
* [ ] * `openOnClick` / `openOnFocus`
* [ ] * `pageSize`
* [ ] * `required`
* [ ] * `resetValue`
* [ ] * `rtl`
* [ ] * `scrollMenuIntoView`
* [ ] * `searchable` / `searchPromptText`
* [ ] * `tabIndex`

---

# Maybe:

* [ ] Prevent values from being popped, was `option.clearableValue === false`
* [ ] Scroll behaviour: should we detect parent? how do we handle the footer?
* [ ] Scroll behaviour: can we overscroll up to show the group heading?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another one is: can the user customize scrollIntoView? For instance, if the option group header has position: sticky then the scroll position should account for its height

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should also do some work around handling more complex requirements for rendering the menu (e.g into a Portal)

* [ ] Internal Required State
* [ ] Touch event handling
* [ ] Scroll the menu into view when it opens
* [ ] * handle `touchOutside`?
* [ ] Async w/ pagination
* [ ] Extention point to reorder / change menu options array when it's created

---

# Later:

* [ ] Reordering of Options (drag and drop)

---

# Done:

* [x] Finalise theme and style customisation framework
* [x] Remove `disabledKey`, clean up similar functionality
* [x] Pseudo-focus Options
* [x] Keyboard navigation
* [x] Make `isDisabled` / `isSelected` etc. props
* [x] Scroll to focused option
* [x] Add `autofocus` prop
* [x] Add HTML Form Input
* [x] Async with:
* [x] * promises
* [x] * better loading state and behaviour
9 changes: 5 additions & 4 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"ignore": ["node-modules/**", "src/index.umd.js"],
"presets": [ "env", "stage-0", "react"],
"plugins": ["transform-class-properties", "transform-object-rest-spread"],
"presets": ["env", "react"],
"ignore": ["node_modules"],
"env": {
"test": {
"plugins": ["istanbul"],
},
"plugins": ["istanbul"]
}
}
}
3 changes: 3 additions & 0 deletions .browserslistrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
> 1%
Last 2 versions
IE 11
8 changes: 0 additions & 8 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,6 @@ end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true
indent_style = tab
translate_tabs_to_spaces = false

[*.json]
indent_style = space
indent_size = 2

[*.yml]
indent_style = space
indent_size = 2

Expand Down
2 changes: 0 additions & 2 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
lib/*
dist/*
coverage/*
examples/dist/*
node_modules/*
bower_components/*
79 changes: 40 additions & 39 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,41 +1,42 @@
module.exports = {
parserOptions: {
ecmaVersion: 6,
sourceType: 'module',
ecmaFeatures: {
experimentalObjectRestSpread: true,
jsx: true,
},
},
env: {
browser: true,
es6: true,
node: true,
},
plugins: ['react'],
rules: {
'curly': [2, 'multi-line'],
'jsx-quotes': 1,
'no-shadow': 0,
'no-trailing-spaces': 0,
'no-underscore-dangle': 0,
'no-unused-expressions': 0,
'object-curly-spacing': [1, 'always'],
'quotes': [2, 'single', 'avoid-escape'],
'react/jsx-boolean-value': 1,
'react/jsx-no-undef': 1,
'react/jsx-uses-react': 1,
'react/jsx-uses-vars': 1,
'react/jsx-wrap-multilines': 1,
'react/no-did-mount-set-state': 1,
'react/no-did-update-set-state': 1,
'react/no-unknown-property': 1,
'react/prop-types': 1,
'react/react-in-jsx-scope': 1,
'react/self-closing-comp': 1,
'react/sort-comp': 1,
'react/sort-prop-types': 1,
'semi': 2,
'strict': 0,
},
parser: 'babel-eslint',
env: {
browser: true,
es6: true,
node: true,
},
plugins: ['react'],
rules: {
'no-unused-vars': [
'error',
{
args: 'after-used',
argsIgnorePattern: '^event$',
ignoreRestSiblings: true,
vars: 'all',
varsIgnorePattern: '^glam$',
},
],
curly: [2, 'multi-line'],
'jsx-quotes': 1,
'no-shadow': 1,
'no-trailing-spaces': 1,
'no-underscore-dangle': 1,
'no-unused-expressions': 1,
'object-curly-spacing': [1, 'always'],
quotes: [2, 'single', 'avoid-escape'],
'react/jsx-boolean-value': 1,
'react/jsx-no-undef': 1,
'react/jsx-uses-react': 1,
'react/jsx-uses-vars': 1,
'react/jsx-wrap-multilines': 1,
'react/no-did-mount-set-state': 1,
'react/no-did-update-set-state': 1,
'react/no-unknown-property': 1,
'react/react-in-jsx-scope': 1,
'react/self-closing-comp': 1,
'react/sort-prop-types': 1,
semi: 2,
strict: 0,
},
};
13 changes: 13 additions & 0 deletions .flowconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
[ignore]

.*/node_modules/cypress/.*

[include]

[libs]

[lints]

[options]

[strict]
3 changes: 0 additions & 3 deletions .gitattributes

This file was deleted.

17 changes: 16 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# Build
lib
dist
examples/dist

# Logs
logs
*.log
Expand All @@ -12,17 +17,27 @@ lib-cov
coverage
.nyc_output

# Cypress
cypress/videos
cypress/screenshots
cypress/support
cypress/plugins

# Dependency directory
node_modules
bower_components

# Publish directory
.publish

# Editor artifacts
# Editor artefacts
.idea

# Other
.DS_Store
.env
yarn.lock
package-lock.json

# Notes
.NOTES.md
4 changes: 4 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
singleQuote: true,
trailingComma: 'es5',
};
11 changes: 8 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
sudo: false
language: node_js
node_js:
- "v4"
- "v8"

before_script:
- npm start & sleep 7
- npm install xvfb

script:
- npm run lint
- npm run test
- npm run coveralls
- npm run test:jest
- npm run test:cypress
Loading