-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React Select v2 #2289
Merged
React Select v2 #2289
Changes from 143 commits
Commits
Show all changes
775 commits
Select commit
Hold shift + click to select a range
92f1037
v2.0.0-beta.1
JedWatson 77aa268
Minor website tweaks
JedWatson c957801
Adding yarn.lock for netlify
JedWatson a54fbba
Updating yarn.lock
JedWatson 6946eea
Export indicator icons for use in customizations
jesstelford eef3ac1
Updating travis script
JedWatson 64ef10c
Merge pull request #2535 from jesstelford/patch-1
JedWatson e9872f7
Tweaking header on website
JedWatson 5e91e18
Fixing a warning in the docs website
JedWatson 2c84c0b
upgrade pretty-proptypes and codesandboxer for fun new features
Noviny e81145b
upgrade guide now has filter and order options for all props
Noviny 3001f29
remove use of Fragment in Select.js
gwyneplaine 0ea7b19
Merge pull request #2544 from JedWatson/v2-remove-fragment
JedWatson 8f59fea
Menu should be wrapped in a div, not a span ref #2544
JedWatson d636a03
Merge pull request #2543 from Noviny/bcon/update-guide-sort-and-filter
JedWatson f079c40
Replacing glam with emotion
JedWatson bf200ac
Fixing issues with the umd index
JedWatson 1c57787
Adding bundlesize reporter to build process
JedWatson dfb885e
Add ability to change input color
lesha1201 d877441
Removing (now) unnecessary white space from flex styles
JedWatson ec76e1d
Flow should ignore dist/
JedWatson 93bf2b9
Fixing snapshots after css change
JedWatson b047767
added universal/ssr rendering support
falconmick 3fa147d
Replacing glam with emotion
JedWatson 839be30
Removing (now) unnecessary white space from flex styles
JedWatson 6944231
Fixing snapshots after css change
JedWatson 3f08b19
Merge branch 'v2' of https://github.com/lesha1201/react-select into l…
gwyneplaine 7a1e9dd
update jest snapshots
gwyneplaine b48b8ed
rerun cypress
gwyneplaine f28c53b
Merge branch 'v2-use-emotion' of github.com:JedWatson/react-select in…
JedWatson dd107fa
Moving dependencies to devDependencies
JedWatson aef6cd3
Merge pull request #2548 from falconmick/v2
JedWatson 722a984
Merge pull request #2549 from JedWatson/lesha1201-v2
JedWatson 453d4db
Fixing browserslistrc, thanks @jamiebuilds
JedWatson b199642
Merge branch 'v2' into v2-use-emotion
JedWatson 3fa5f68
Add CircleCI config
JedWatson 65872e6
Merge pull request #2547 from JedWatson/v2-use-emotion
JedWatson 8a61132
Updating TODO
JedWatson b52bb4d
v2.0.0-beta.2
JedWatson 4496200
fix group component in experimental
gwyneplaine c6ef219
Merge branch 'v2' into v2-setup-circleci
JedWatson 503863b
Adding changes from #2559
JedWatson 8df83aa
Updating e2e script
JedWatson 6348950
Updating e2e task thanks to @willmendesneto
JedWatson 6a7bb50
Merge pull request #2557 from JedWatson/v2-setup-circleci
JedWatson f3d937c
Updating dependencies
JedWatson a01fd94
Simplify flow distribution
TrySound 91e6a73
added documentation on how to SSR
falconmick 58feef3
Merge remote-tracking branch 'jed/v2' into v2
falconmick 82f654c
Fixing a bug where nextProps is not always used when building menu op…
JedWatson 434008e
Ensuring inputValue is always a string in buildMenuOptions
JedWatson 124dad0
initial commit of multi-value keyboard functionality
gwyneplaine ba16de9
added inputValue checks to multivalue keyboard input handle
gwyneplaine f190dec
added onValueClick prop
gwyneplaine 8f9312f
nullify focus value on clear, add onValueClick trigger to space key p…
gwyneplaine 3ba8ab5
onValueClick implementation for Multi and Single Value components
gwyneplaine baa578c
refactor focusedValue detection logic in Select.js
gwyneplaine bee7510
remove onValueClick implementation;
gwyneplaine f348c58
Adding --isDisabled classname to Option
eemeli 6743fab
fix control showing scroll bar, fix overflowing options in menu
gwyneplaine 60b3304
added flex-basis to menuList component to fix overflow issue in ie11
gwyneplaine 5a94db1
trigger CI rerun
gwyneplaine 9401a3e
Updating CircleCI docker container for cypress
JedWatson 869ea67
Merge pull request #2593 from JedWatson/v2-ie11-fixes
JedWatson 13b62f4
Merge pull request #2589 from eemeli/v2-add-option-disabled-classname
JedWatson f530430
Merge pull request #2585 from falconmick/v2
JedWatson b3bfb67
Merge pull request #2564 from JedWatson/v2-fix-experimental
JedWatson 2371278
Moving SSR documentation to the Advanced guide
JedWatson 766e6d9
initial commit of multi-value keyboard functionality
gwyneplaine addff0e
added inputValue checks to multivalue keyboard input handle
gwyneplaine 9168cb1
added onValueClick prop
gwyneplaine 1cb3df2
nullify focus value on clear, add onValueClick trigger to space key p…
gwyneplaine 25e9894
onValueClick implementation for Multi and Single Value components
gwyneplaine 0786771
refactor focusedValue detection logic in Select.js
gwyneplaine d29b342
remove onValueClick implementation;
gwyneplaine f499b4d
removed onValueClick from basicMulti example
gwyneplaine 6b79efe
Cleaning up focusValue implementation
JedWatson 31d4236
Fixing the getNextFocusedValue method
JedWatson 6759999
Merge branch 'v2-multi-value-keyboard' of github.com:JedWatson/react-…
JedWatson 42a334b
Ensuring the focused option is cleared when an option is selected
JedWatson 5ddef45
Fixing a bug where backspaceRemovesValue breaks removing focused options
JedWatson 30afdd5
Merge pull request #2584 from JedWatson/v2-multi-value-keyboard
JedWatson d545228
Removing console.log from examples
JedWatson bac99e8
Remove maxValueHeight prop
JedWatson d7c4233
Updating snapshots
JedWatson b737aa5
Removing remaining code linked to the maxValueHeight feature
JedWatson 1f0bdc1
Updating snapshots
JedWatson f899cfe
Merge pull request #2595 from JedWatson/v2-remove-max-value-height
JedWatson 0a77534
remove flex from menu to address ie11 concerns
gwyneplaine 60910df
Merge pull request #2596 from JedWatson/v2-remove-menu-flex
JedWatson 84a3007
Ensuring the input has focus when the menu opens, fixes #2591
JedWatson 4e11baf
Merge pull request #2576 from TrySound/simple-flow-distribution
JedWatson 8d97e3e
Hardening SSR compatibility, fixes #2555
JedWatson 9009fff
update innerRef key in innerProps to be ref for better developer expe…
gwyneplaine cf2557d
refactor cx implementation to accomodate new className construction a…
gwyneplaine 7ffc0e0
update snapshots to account for change from referencing primitive com…
gwyneplaine a1cdcf2
remove reference to input primitive in dummyinput file
gwyneplaine ab820ec
prep changelog for beta.3 release
gwyneplaine 649d1fe
Update HISTORY.md
gwyneplaine b6e0045
Merge pull request #2602 from JedWatson/v2-innerRef-to-ref
JedWatson f2ab6ad
add classNamesPrefix, add deprecation warning for old className funct…
gwyneplaine 813bb6d
fix snapshot
gwyneplaine cd3662b
Merge branch 'v2' of github.com:JedWatson/react-select into v2
JedWatson bc75878
Exporting Async, AsyncCreatable and Creatable in main bundle
JedWatson 928f6d2
Merge pull request #2605 from JedWatson/v2-classNamePrefix
JedWatson 899fa6e
Merge branch 'v2' of github.com:JedWatson/react-select into v2
JedWatson ce9b37e
Update HISTORY.md
gwyneplaine 138e1d7
Merge pull request #2603 from JedWatson/v2-update-history
JedWatson ec38802
Updating changelog for beta.3
JedWatson cf12555
v2.0.0-beta.3
JedWatson 141fb84
remove flow-fix-me, resolve merge conflicts
gwyneplaine b3aeadc
Merge branch 'MikeLimeRocket-v2' into v2
gwyneplaine d96826b
fix DummyInput ref
gwyneplaine dab8145
update changelog
gwyneplaine eefdfe9
fix custom indicator separator example
gwyneplaine 3c68032
v2.0.0-beta.4
gwyneplaine 004d9d8
Add brief class name explanation to Styles docs
fozcodes ca7b5fc
Fix spelling of "IndicatorSeparator"
robertcoopercode 1e99d6c
fix(Select): use getOptionValue to compare values when filtering sele…
9e96c2f
add popout example to advanced docs;
jossmac ab600f0
update snapshots
jossmac 1aa09e9
Merge pull request #2623 from JedWatson/popout-select
JedWatson 2853384
prop name change
jossmac 9e4158f
Merge pull request #2624 from JedWatson/prop-name-change
gwyneplaine 51c9907
v2.0.0-beta.5
gwyneplaine abfd6d8
Fix Warning: Unknown prop `css` on <div> tag in div (created by Singl…
guigs 95b1d2b
Merge pull request #2628 from guigs/patch-1
gwyneplaine 575b495
Merge pull request #2615 from fozcodes/add_classname_info_to_styles_docs
gwyneplaine 5e6672c
Merge branch 'v2' of https://github.com/JedWatson/react-select into v2
gwyneplaine cd03fdc
add removedValue to actionMeta
gwyneplaine f1bb484
Merge pull request #2637 from JedWatson/v2-give-removed-value
JedWatson 9969101
update styles docs to do with className and classNamePrefix
gwyneplaine 104e62e
Merge pull request #2632 from JedWatson/v2-update-className-docs
JedWatson f2b3df3
change internal component ref to innerRef to maintain compatibility w…
gwyneplaine cc7de65
fix snapshots and tests
gwyneplaine b21f595
Merge pull request #2631 from JedWatson/v2-revert-ref-to-innerRef
JedWatson e894af2
Merge pull request #2620 from robertcoopercode/patch-1
JedWatson 94932a2
removed flex from menu and menuList
gwyneplaine eb7b2da
Merge branch 'v2' of https://github.com/JedWatson/react-select into v2
gwyneplaine 87bf28a
Merge branch 'v2' into pr/2622
JedWatson 7ed688d
Merge pull request #2622 from inv8der/use-getOptionValue-to-filter
JedWatson ada7379
Allow Creatable option first
iojichervo 9f309e8
rename prop to createOptionPosition with a string value type instead …
gwyneplaine abe089b
Merge pull request #2638 from JedWatson/iojichervo-creatable-option-f…
gwyneplaine 7f89f32
improve touch handling
jossmac b735c2d
Merge pull request #2639 from JedWatson/improve-touch-handling
gwyneplaine 69ad427
v2.0.0-beta.6
gwyneplaine 6202304
Upgrade package "flow-bin" to v0.72.0
61f3cba
Fix Flowtyping
76a727e
Re-render when defaultOptions changes
jesstelford af5d386
Example indentation fix
JuhQ 732fb90
Change isOptionDisabled to have the same inputs as isOptionSelected
94df8a7
Merge pull request #2687 from JuhQ/patch-2
gwyneplaine e5f8388
Change type for indicator components be nullable
mike1808 3789000
Add meta to onChange when isMulti
cc3f1a1
Merge pull request #2646 from lunij/v2-flowtype-update
gwyneplaine efe2bfd
fix loadingDot not using emotions css fn to compile styles object, re…
gwyneplaine e1eb022
changing all emotionCss invocations to css(), changed styling functio…
gwyneplaine 9a67cc8
added makeAnimated method, animated/index export default is now an em…
gwyneplaine 56de1bb
[v2] fix className composition
nihgwu 2728e40
Fix for #2716 - Missing type annotation for U.
himerus 30dee63
Merge pull request #2732 from himerus/bug/2716-type-annotation
gwyneplaine 22e0f2c
change onMenuScrollToTop and onMenuScrollToBottom as optional properties
mike1808 f9ddfa3
Fix typo in tst
JuhQ 9b1cc2c
Merge pull request #2748 from teamable-software/v2-fix-select-prop-types
gwyneplaine 5122376
fix default behaviour for hideSelectedOptions property
jossmac f84612d
update snapshots
jossmac 9c5e84f
Merge pull request #2753 from JedWatson/v2-hide-selected-default
JedWatson 3340908
Merge pull request #2717 from SimeonC/v2-multi-select-option-meta
JedWatson 18e0620
Merge pull request #2749 from JuhQ/patch-3
JedWatson 7342e07
Merge pull request #2723 from JedWatson/v2-fix-loading-dot-styles
JedWatson 7409317
Merge pull request #2733 from nihgwu/neo/className
JedWatson e855b8d
Optimising applyPrefixToName
JedWatson a0adb34
Replacing .includes with .indexOf for IE11, fixes #2701
JedWatson 91a7490
Don't render the menu when messages return null
JedWatson 005470a
fix to export of animated/index to be non-breaking
gwyneplaine 68a65c2
Merge pull request #2708 from teamable-software/v2-update-components-…
JedWatson 76ef016
fix mobile scroll blocking
jossmac 7424383
Merge pull request #2756 from JedWatson/fix-mobile-scroll-blocking
JedWatson d955def
Merge pull request #2754 from JedWatson/v2-hide-menu-with-null-message
JedWatson 69abb3f
Pipe the onTouchEnd event down to MultiValueRemove's props
chuckbergeron dad61a2
export makeAnimated from src/index
gwyneplaine 0aa496e
Merge pull request #2724 from JedWatson/v2-make-animated
gwyneplaine 3a1ff97
Merge pull request #2762 from chuckbergeron/fix/multiValueRemove
gwyneplaine ab42d2d
remove unnecessary aria props from Input and Group components
gwyneplaine 9455736
removed unnecessary aria attributes from Menu and Option
gwyneplaine b7a3534
remove allytext from loadingIndicator
gwyneplaine 8bba325
aria hidden true on indicators and svgs
gwyneplaine 774e979
clean up flow types LoadingIndicator class, add aria-hidden to passe…
gwyneplaine 27a7d66
initial live-region implementation
gwyneplaine 612dd62
accessibility wip, added focused options and inputvalue change announ…
gwyneplaine 363d635
add utility methods for aria live region updates for option focus, se…
gwyneplaine 7b5089d
removed instructions from menuIsOpen and moved to focusOption and foc…
gwyneplaine 5ccccc3
react-aria-live implementation w aria-live-regions
gwyneplaine 053edd7
add instructions and valueEvent functions for defining ariaLiveSelect…
gwyneplaine 2b17ed4
added accessibility folder, added helper fucntions for aria messages …
gwyneplaine b064304
update cypress tests
gwyneplaine 8b169af
added null checks for values passed into announceStatus
gwyneplaine 8f5cb3a
update snapshots
gwyneplaine b8fc4c3
updated tests to reflect changes to accessibility implementation
gwyneplaine 4f799ca
revert menuList innerProps removal for more consistent api
gwyneplaine 3e066cb
optimise constructAriaLiveMssage function for readability
gwyneplaine b3fb7d7
Merge pull request #2581 from JedWatson/v2-live-region-implementation
gwyneplaine 2c40499
beta.7 changelogs
gwyneplaine 2240a48
update changelog
gwyneplaine b290b42
updates to history and yarnlock file
gwyneplaine f95f349
Merge pull request #2766 from JedWatson/v2-beta.7-changelogs
gwyneplaine 322a097
specify file in path of imports for rollup build resolution
gwyneplaine 22dff31
v2.0.0-beta.7
gwyneplaine 22e7ae7
Pressing <Enter> in IME mode should not select a option
shamabe 6733312
Add bullet re: ref name change
jossmac c40ea23
Merge pull request #2652 from jesstelford/patch-2
gwyneplaine f1cb4ee
Tidy up rollup config (#2788)
TrySound 74864af
Prefer more descriptive esm word instead of es
TrySound 8e83dff
Added new prop that allows menu to be automatically closed when the …
125d84a
apply memoize-one and react-fast-compare to components Cache in Selec…
gwyneplaine a3d8baa
Merge pull request #2814 from JedWatson/v2-components-cache
JedWatson 1704201
Merge pull request #2767 from shamabe/fix-for-ime
JedWatson 4ebdec8
v2 readme
gwyneplaine 9b7829f
remove deprecation warning and backward compatibility logic
gwyneplaine e3d862a
Remove primitives and update MultiValue components
JedWatson 930ea68
fix cypress test failure
gwyneplaine 4b500d9
Merge pull request #2695 from SimeonC/v2-improve-isoptiondisabled
JedWatson 3036c6c
Change filterOption from hard-coded prop to defaultProp
JedWatson dd033b1
Merge pull request #2821 from JedWatson/v2-remove-primitives
JedWatson 033cba7
update snapshots
gwyneplaine 8aebc03
Merge pull request #2809 from Vynlar/v2
JedWatson 97d2760
Merge pull request #2818 from JedWatson/v2-readme
JedWatson 08ef385
Merge pull request #2820 from JedWatson/v2-remove-dep-warn
JedWatson 5f21735
remove invocation of null in defaultOptions to account for extract-re…
gwyneplaine 4967ba1
Merge pull request #2822 from JedWatson/v2-default-async-filters
JedWatson c3d2e8a
change menuList to declare innerRef instead of nest it within innerProps
gwyneplaine 75707e7
Control now declares innerRef outside of innerProps object
gwyneplaine cb15dbc
update innerRef of Option component to be independent of innerProps p…
gwyneplaine f36fed2
update snapshots
gwyneplaine 7a3c5c4
update upgradeGuide with up to date information circa custom componen…
gwyneplaine f3e3932
update reference to plunkr to reference codesandbox in stead
gwyneplaine 37b83fd
move ISSUE_TEMPLATE to .github/ISSUE_TEMPLATE
gwyneplaine 20ceabc
Removing unused Travis config
JedWatson 4cd69d5
Merge pull request #2825 from JedWatson/v2-update-issue-template
JedWatson cc095f8
Merge pull request #2824 from JedWatson/v2-redistribute-innerRef
JedWatson 111f513
update contributing md
gwyneplaine 7567283
Merge pull request #2641 from TrySound/es-to-esm
JedWatson 5ac6876
Merge pull request #2826 from JedWatson/v2-update-contributing.md
JedWatson aa22e49
update changelog in prep for v2.0.0 release
gwyneplaine 562c02b
Merge pull request #2828 from JedWatson/v2-release-changelog
JedWatson 24f85f8
Merge branch 'master' into v2
gwyneplaine f85fe6d
inlining react-fast-compare to get around rollup configuration issues
gwyneplaine b455622
Readme improvements for v2
JedWatson 8261f19
Merge branch 'v2' of github.com:JedWatson/react-select into v2
JedWatson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
# Order of focus: | ||
|
||
* [ ] Lock scrolling on Menu (enable with prop) | ||
* [ ] Pass more (and consistent?) props and state from Select to Components | ||
* [x] Fix issue with how the mouse hover interacts with keyboard scrolling | ||
* [x] Ability to customise built-in strings | ||
* [ ] Tags mode (Creatable) | ||
* [-] Make inputValue a controllable prop | ||
* [ ] Make menuIsOpen a controllable prop | ||
* [ ] Render menu always open | as a dropdown | not at all | ||
* [ ] Handle changing of isDisabled prop | ||
* [ ] Virtualisation | ||
* [ ] Documentation | ||
* [ ] * Props | ||
* [ ] * Customisation | ||
* [ ] Upgrade Guide from v1 -> v2 | ||
* [ ] Cleanup | ||
|
||
--- | ||
|
||
# Review: | ||
|
||
* [ ] Make sure all on{Event} props that make sense are implemented | ||
* [ ] Check old props that may need to be brought forward: | ||
* [ ] * `autoBlur` (was for mobile -- still necessary?) | ||
* [ ] * `autosize` (not sure why this needs to be supported?) | ||
* [ ] * `backspaceToRemoveMessage` | ||
* [ ] * `className` (for container) | ||
* [ ] * `clearable` (can just provide no component) | ||
* [ ] * `clearAllText` / `clearValueText` (can override component?) | ||
* [ ] * `id` (for container) / `inputId` | ||
* [ ] * `onBlurResetsInput` / `onCloseResetsInput` / `onSelectResetsInput` | ||
* [ ] * `onClose` / `onOpen` | ||
* [ ] * `onMenuScrollToBottom` | ||
* [ ] * `openOnClick` / `openOnFocus` | ||
* [ ] * `pageSize` | ||
* [ ] * `required` | ||
* [ ] * `resetValue` | ||
* [ ] * `rtl` | ||
* [ ] * `scrollMenuIntoView` | ||
* [ ] * `searchable` / `searchPromptText` | ||
* [ ] * `tabIndex` | ||
|
||
--- | ||
|
||
# Maybe: | ||
|
||
* [ ] Prevent values from being popped, was `option.clearableValue === false` | ||
* [ ] Scroll behaviour: should we detect parent? how do we handle the footer? | ||
* [ ] Scroll behaviour: can we overscroll up to show the group heading? | ||
* [ ] Internal Required State | ||
* [ ] Touch event handling | ||
* [ ] Scroll the menu into view when it opens | ||
* [ ] * handle `touchOutside`? | ||
* [ ] Async w/ pagination | ||
* [ ] Extention point to reorder / change menu options array when it's created | ||
|
||
--- | ||
|
||
# Later: | ||
|
||
* [ ] Reordering of Options (drag and drop) | ||
|
||
--- | ||
|
||
# Done: | ||
|
||
* [x] Finalise theme and style customisation framework | ||
* [x] Remove `disabledKey`, clean up similar functionality | ||
* [x] Pseudo-focus Options | ||
* [x] Keyboard navigation | ||
* [x] Make `isDisabled` / `isSelected` etc. props | ||
* [x] Scroll to focused option | ||
* [x] Add `autofocus` prop | ||
* [x] Add HTML Form Input | ||
* [x] Async with: | ||
* [x] * promises | ||
* [x] * better loading state and behaviour |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
{ | ||
"ignore": ["node-modules/**", "src/index.umd.js"], | ||
"presets": [ "env", "stage-0", "react"], | ||
"plugins": ["transform-class-properties", "transform-object-rest-spread"], | ||
"presets": ["env", "react"], | ||
"ignore": ["node_modules"], | ||
"env": { | ||
"test": { | ||
"plugins": ["istanbul"], | ||
}, | ||
"plugins": ["istanbul"] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
> 1% | ||
Last 2 versions | ||
IE 11 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
lib/* | ||
dist/* | ||
coverage/* | ||
examples/dist/* | ||
node_modules/* | ||
bower_components/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,41 +1,42 @@ | ||
module.exports = { | ||
parserOptions: { | ||
ecmaVersion: 6, | ||
sourceType: 'module', | ||
ecmaFeatures: { | ||
experimentalObjectRestSpread: true, | ||
jsx: true, | ||
}, | ||
}, | ||
env: { | ||
browser: true, | ||
es6: true, | ||
node: true, | ||
}, | ||
plugins: ['react'], | ||
rules: { | ||
'curly': [2, 'multi-line'], | ||
'jsx-quotes': 1, | ||
'no-shadow': 0, | ||
'no-trailing-spaces': 0, | ||
'no-underscore-dangle': 0, | ||
'no-unused-expressions': 0, | ||
'object-curly-spacing': [1, 'always'], | ||
'quotes': [2, 'single', 'avoid-escape'], | ||
'react/jsx-boolean-value': 1, | ||
'react/jsx-no-undef': 1, | ||
'react/jsx-uses-react': 1, | ||
'react/jsx-uses-vars': 1, | ||
'react/jsx-wrap-multilines': 1, | ||
'react/no-did-mount-set-state': 1, | ||
'react/no-did-update-set-state': 1, | ||
'react/no-unknown-property': 1, | ||
'react/prop-types': 1, | ||
'react/react-in-jsx-scope': 1, | ||
'react/self-closing-comp': 1, | ||
'react/sort-comp': 1, | ||
'react/sort-prop-types': 1, | ||
'semi': 2, | ||
'strict': 0, | ||
}, | ||
parser: 'babel-eslint', | ||
env: { | ||
browser: true, | ||
es6: true, | ||
node: true, | ||
}, | ||
plugins: ['react'], | ||
rules: { | ||
'no-unused-vars': [ | ||
'error', | ||
{ | ||
args: 'after-used', | ||
argsIgnorePattern: '^event$', | ||
ignoreRestSiblings: true, | ||
vars: 'all', | ||
varsIgnorePattern: '^glam$', | ||
}, | ||
], | ||
curly: [2, 'multi-line'], | ||
'jsx-quotes': 1, | ||
'no-shadow': 1, | ||
'no-trailing-spaces': 1, | ||
'no-underscore-dangle': 1, | ||
'no-unused-expressions': 1, | ||
'object-curly-spacing': [1, 'always'], | ||
quotes: [2, 'single', 'avoid-escape'], | ||
'react/jsx-boolean-value': 1, | ||
'react/jsx-no-undef': 1, | ||
'react/jsx-uses-react': 1, | ||
'react/jsx-uses-vars': 1, | ||
'react/jsx-wrap-multilines': 1, | ||
'react/no-did-mount-set-state': 1, | ||
'react/no-did-update-set-state': 1, | ||
'react/no-unknown-property': 1, | ||
'react/react-in-jsx-scope': 1, | ||
'react/self-closing-comp': 1, | ||
'react/sort-prop-types': 1, | ||
semi: 2, | ||
strict: 0, | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
[ignore] | ||
|
||
.*/node_modules/cypress/.* | ||
|
||
[include] | ||
|
||
[libs] | ||
|
||
[lints] | ||
|
||
[options] | ||
|
||
[strict] |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = { | ||
singleQuote: true, | ||
trailingComma: 'es5', | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,13 @@ | ||
sudo: false | ||
language: node_js | ||
node_js: | ||
- "v4" | ||
- "v8" | ||
|
||
before_script: | ||
- npm start & sleep 7 | ||
- npm install xvfb | ||
|
||
script: | ||
- npm run lint | ||
- npm run test | ||
- npm run coveralls | ||
- npm run test:jest | ||
- npm run test:cypress |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another one is: can the user customize
scrollIntoView
? For instance, if the option group header hasposition: sticky
then the scroll position should account for its heightThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should also do some work around handling more complex requirements for rendering the menu (e.g into a Portal)