[V2] Add meta to onChange when isMulti #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of using isMulti and ecspecially with `hideSelectedOptions = false` the action meta should include the option that is being selected/deselected.
gwyneplaine
changed the title
|
@JedWatson this seems like a viable solution to me, but wanted to sanity check potentially loading the actionMeta with conditional values like this with you. |
|
@gwyneplaine looks good to me, this is a valid use of what action meta was intended for @SimeonC thanks for the PR, and the new tests as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of using isMulti and especially with
hideSelectedOptions = false(for deselect) the action meta should include the option that is being selected/deselected.This is kind of an extension of #2637. Only applies to
isMulti.