Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new prop that allows the user to have the menu close when they scroll the window. This is useful when you have a portaled menu inside of a scrollable view. Without this, the dropdown often ends up in strange places.
A few notes:
I was unable to get the
npm start
server to run, which means I can't run the cypress tests.Here's the error I got:
It seems like
transform-object-rest-spread
isn't being enabled despite it being inside of.babelrc
.I attempted to add unit tests, but since this feature relies heavily on binding listeners to the document object, I was unable to write any that were meaningful. Considering the
touchdown
et. al. handlers are not covered in the unit tests, I figured it would be reasonable for mine to not be as well.Flow types + linting check out fine.
If someone is willing to help me get my server to start, I'm happy to add some cypress tests that cover the new functionality.
Great job with the new API, migrating from v1 has been wonderful! I've deleted several hundred lines of code that are no longer necessary because of the new styling/component system.
Keep it up!