Allow Node as placeholder #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original issue was for version 1.x. In version 2.x you can replace every component that react-select uses. So this merge request is pretty unnecessary imo. |
|
@Rall3n Custom components don't really help with the restricting prop type on Select. Yes, they technically allow for an alternative way of producing a custom placeholder, but the ergonomics of doing that are really rather clumsy, especially when compared to what's possible already with the default Placeholder -- provided that you ignore the prop type warning that I'm seeking to get rid of here. |
|
@gwyneplaine Any chance of getting this looked at? It's literally a single-line fix, plus associated tests. |
eemeli
force-pushed
the
node-placeholder
branch
from
25abb4e
to
cace840
Compare
|
Rebased on latest master. |
|
I can't really see any downside to this. Thanks @eemeli 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1378
Even though Placeholder accepts
Nodechildren, theplaceholderprop on Select expectsstringtype. This causes an unnecessary dev mode warning when using e.g. a React element as a placeholder, even though it already works.This PR relaxes the prop type to allow any node as placeholder. I also fixed the placeholder tests to actually test what they say they test.