BuildMenuOptions only when menu is opened #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vadimka123 this is a very helpful change. Will be included in the next release. |
|
For anyone having troubles updating from 2.4.4 to latest releases, this looks like it could be a breaking change depending on how you interacted with the menu ( for example if your logic had a custom menu and a reference to it, your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very big performance issue: buildMenuOptions only when menu is opened
I'm have page with ~1000 selects with a ~1000 options. When render this page it takes ~ 40-50s and while page either hangs terribly or crashed. After this update page render takes 10s and there are no hangs. It's very need update.