-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resultLimit prop limiting the amount of rendered options #4515
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c2beb0:
|
Could you filter the options before passing them into the Select component? |
I could, yeah. But it's incredibly frustrating that I'd have to hoist and manage input state and search logic, which Select already has, just because i want to limit the amount of options that are rendered. This feature would be really helpful to have available, when dealing with thousands of options, which is often the case. Also, being able to limit number of rendered results is an easy way to optimize lists that are more relevant for searching than browsing. Even my battlestation is sluggish at best when dealing with large lists; https://codesandbox.io/s/react-codesandboxer-example-forked-sogqi Just setting a hard limit with |
Closing because of the major rewrite in progress. |
Add a
resultLimit
prop that prevents rendering too many results. Useful if the number of options are in the thousands.Indirectly addresses #4504
Addresses #4516