Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow it to be browserified from npm #8

Merged
merged 2 commits into from Sep 19, 2014
Merged

Conversation

brigand
Copy link
Contributor

@brigand brigand commented Sep 18, 2014

The transform field is read when the parent project runs browserify. Someone else can probably help set up webpack if it needs a config file for this.

CSS is an unsolved issue, but you could provide the compiled CSS and tell people to just copy it out of node_modules in their build tasks, or @import it in their LESS.

@JedWatson
Copy link
Owner

Thanks @brigand, I was wondering how to get this to work!

Seems a shame that reactify needs to be included as a dependency (rather than devDependency) for browserify to work, but I assume that's a limitation of browserify itself...?

JedWatson added a commit that referenced this pull request Sep 19, 2014
allow it to be browserified from npm
@JedWatson JedWatson merged commit c3a3099 into JedWatson:master Sep 19, 2014
@brigand
Copy link
Contributor Author

brigand commented Sep 19, 2014

@JedWatson it's a limitation of npm. If require('reactify') can't find it, then bundling will fail.

The alternative is to tell people to npm install reactify if they want to use browserify. require searches upwards to try to find the module, so a parent project having it installed makes it available to your project. Most browserify users will have reactify unless they're not using jsx (e.g. CoffeeScript users).

Methuselah96 added a commit to Methuselah96/react-select that referenced this pull request Nov 14, 2020
* Fix E2E CI

* yarn cypress install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants