Integrate pump manager into main script. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 3841464 on pump_manager into ** on master**. |
mtlynch
approved these changes
Mar 31, 2017
greenpithumb/greenpithumb.py
Outdated
| local_clock = clock.LocalClock() | ||
| # The MCP3008 spec and Adafruit library use different naming for the | ||
| # Raspberry Pi GPIO pins, so we translate as follows: | ||
| # * CLK -> CLK | ||
| # * CS/SHDN -> CS | ||
| # * DOUT -> MISO | ||
| # * DIN -> MOSI | ||
| raspberry_pi_io = pi_io.IO(GPIO) |
There was a problem hiding this comment.
Suggest just defining this inline since it's only used once, like
water_pump = pump.Pump(pi_io.IO(GPIO), utc_clock, wiring_config.gpio_pins.pump)
|
Changes Unknown when pulling 4422e2e on pump_manager into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70