Adding poller for camera #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeetShetty
reviewed
Apr 3, 2017
| def make_camera_poller(photo_interval, image_path, record_queue): | ||
| local_clock = clock.LocalClock() | ||
| poller_factory = poller.SensorPollerFactory(local_clock, photo_interval, | ||
| record_queue) |
There was a problem hiding this comment.
(Optional) Feels strange to create a new poller factory just for the camera poller. My first thought was to just add a poll_interval argument to create_camera_poller, but that also doesn't feel good.
There was a problem hiding this comment.
Yeah, I agree but I couldn't think of anything either. My initial approach was to add a photo_interval parameter to the main sensor factory but that felt klunkier.
JeetShetty
approved these changes
Apr 3, 2017
mtlynch
force-pushed
the
bring-back-camera
branch
from
9693a04
to
fd8f7d8
Compare
Adding a separate photo interval flag to control frequency of photos Adding logging message in camera_manager
mtlynch
force-pushed
the
bring-back-camera
branch
from
fd8f7d8
to
6fe5a62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a separate photo interval flag to control frequency of photos and log output for the camera manager.