Changing camera to save hi res files and use UTC time #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing camera poller to use UTC time and a string timestamp format to match the database timestamp format. Changing the camera's resolution to be the max resolution.
JeetShetty
reviewed
Apr 4, 2017
greenpithumb/camera_manager.py
Outdated
| @@ -3,31 +3,34 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| # Format of filename to write for camera image file (assumes timestamp is in | |||
| # UTC), as YYYY-MM-DDTHH:MM:SSZ (ISO 8601 format) | |||
| _FILENAME_FORMAT = '%Y-%m-%dT%H%M%SZ.jpg' | |||
There was a problem hiding this comment.
(optional) Suggest '%H-%M-%S' for readability. Seconds-level precision also seems unnecessary.
There was a problem hiding this comment.
Oh good point. The encoder in the frontend will still JSONify it with seconds-level precision, but maybe we can address that later.
JeetShetty
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing camera poller to use UTC time and a string timestamp format to match
the database timestamp format.
Changing the camera's resolution to be the max resolution.