Refactoring method names in DbStore classes #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calling semantics of the DbStore classes are a bit redundant because we end up with calls like 'temperature_store.store_temperature'. The class name gives the type, so we don't have to repeat it in the method. I think if we do this, it opens up the door to some refactoring around managing multiple db store instances of different types.
JeetShetty
approved these changes
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calling semantics of the DbStore classes are a bit redundant because we
end up with calls like 'temperature_store.store_temperature'. The class name
gives the type, so we don't have to repeat it in the method. I think if we do
this, it opens up the door to some refactoring around managing multiple
db store instances of different types.