Support multiple streams #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Increment local ID * Fix test_push_dir test * Fix another test * Document the _local_id attribute * Increment local ID in async code * Fix tests * Fix test_issue29 * Add tests for local ID wraparound * thevalue -> the value
* Move all ADB I/O into _AdbIOManager / _AdbIOManagerAsync classes * Fix 'banner' -> 'banner2' * Update adb_shell/adb_device.py * Update adb_shell/adb_device_async.py
* Add helper functions * Add tests
* Support multiple streams (sync) * Don't log empty data * Remove unreachable else block; add note about thread safety * Disable failing test * Add a note about the locks; close the connection in `connect()`; and improve comments in `read()` * Remove unnecessary (redundant) check * Remove unused variable * Clean up method names * Add comments about changing exceptions * Change exception types * Revise failing test * Add test * Add test * Add test * Add comments * Rename bulk_read_list -> bulk_read_data, bulk_write_list -> bulk_write_data * Rename bulk_read_list -> bulk_read_data, bulk_write_list -> bulk_write_data * Documentation + cleanup * Linting fix * Only use 1 lock * Revert "Only use 1 lock" This reverts commit 6d78057. * More robust lock usage * Remove outdated documentation; rename tests * Checkout tests/test_adb_device_async.py from multiple-streams * Use a lock to protect self._local_id * Fix typo
* Support multiple streams (async) * Documentation fixes * Use a lock to protect self._local_id
…#178) * Change the signature for AdbDevice._open() and AdbDeviceAsync._open() * Add blank line
* Document `_AdbTransactionInfo.args_match` * Fix documentation of read() methods * Remove duplicate documentation * Add link to _AdbIOManager.connect / _AdbIOManagerAsync.connect * Remove InterleavedDataError exception * Bunch of documentation fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.