Add tests to make sure the key is only loaded once

JeffLIrion · Jun 27, 2020 · 79b164b · 79b164b
1 parent e1574c1
commit 79b164b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/tests/test_adb_manager_async.py b/tests/test_adb_manager_async.py
@@ -357,11 +357,18 @@ async def test_connect_success_with_priv_key(self):
         """Test when the connect attempt is successful when using a private key.
 
         """
-        with async_patchers.patch_connect(True)[self.PATCH_KEY], patch('androidtv.adb_manager.adb_manager_async.open', open_priv), patch('androidtv.adb_manager.adb_manager_async.PythonRSASigner', return_value=None):
+        with async_patchers.patch_connect(True)[self.PATCH_KEY], patch('androidtv.adb_manager.adb_manager_async.open', open_priv), patch('androidtv.adb_manager.adb_manager_async.PythonRSASigner', return_value="TEST"):
             self.assertTrue(await self.adb.connect())
             self.assertTrue(self.adb.available)
             self.assertTrue(self.adb._available)
 
+        with async_patchers.patch_connect(True)[self.PATCH_KEY]:
+            with patch('androidtv.adb_manager.adb_manager_async.open') as patch_open:
+                self.assertTrue(await self.adb.connect())
+                self.assertTrue(self.adb.available)
+                self.assertTrue(self.adb._available)
+                assert not patch_open.called
+
     @awaiter
     async def test_connect_success_with_priv_pub_key(self):
         """Test when the connect attempt is successful when using private and public keys.

diff --git a/tests/test_adb_manager_sync.py b/tests/test_adb_manager_sync.py
@@ -250,7 +250,7 @@ def test_adb_pull_success(self):
     def test_adb_screencap_fail_unavailable(self):
         """Test when an ADB screencap command fails because the connection is unavailable.
 
-        """        
+        """
         self.assertFalse(self.adb.available)
         self.assertIsNone(self.adb.screencap())
 
@@ -327,11 +327,18 @@ def test_connect_success_with_priv_key(self):
         """Test when the connect attempt is successful when using a private key.
 
         """
-        with patchers.patch_connect(True)[self.PATCH_KEY], patch('androidtv.adb_manager.adb_manager_sync.open', open_priv), patch('androidtv.adb_manager.adb_manager_sync.PythonRSASigner', return_value=None):
+        with patchers.patch_connect(True)[self.PATCH_KEY], patch('androidtv.adb_manager.adb_manager_sync.open', open_priv), patch('androidtv.adb_manager.adb_manager_sync.PythonRSASigner', return_value="TEST"):
             self.assertTrue(self.adb.connect())
             self.assertTrue(self.adb.available)
             self.assertTrue(self.adb._available)
 
+        with patchers.patch_connect(True)[self.PATCH_KEY]:
+            with patch('androidtv.adb_manager.adb_manager_sync.open') as patch_open:
+                self.assertTrue(self.adb.connect())
+                self.assertTrue(self.adb.available)
+                self.assertTrue(self.adb._available)
+                assert not patch_open.called
+
     def test_connect_success_with_priv_pub_key(self):
         """Test when the connect attempt is successful when using private and public keys.