Add from_base() methods (#286)

JeffLIrion · Jan 18, 2022 · ccfa1d9 · ccfa1d9
1 parent ff6105f
commit ccfa1d9
Show file tree

Hide file tree

Showing 7 changed files with 125 additions and 5 deletions.
diff --git a/androidtv/__init__.py b/androidtv/__init__.py
@@ -83,11 +83,11 @@ def setup(
 
     # Fire TV
     if aftv.device_properties.get("manufacturer") == "Amazon":
-        aftv.__class__ = FireTVSync
+        aftv = FireTVSync.from_base(aftv)
 
     # Android TV
     else:
-        aftv.__class__ = AndroidTVSync
+        aftv = AndroidTVSync.from_base(aftv)
 
     # Fill in commands that are specific to the device
     aftv._fill_in_commands()  # pylint: disable=protected-access

diff --git a/androidtv/androidtv/androidtv_async.py b/androidtv/androidtv/androidtv_async.py
@@ -50,6 +50,36 @@ def __init__(
         # fill in commands that can vary based on the device
         BaseAndroidTV._fill_in_commands(self)
 
+    @classmethod
+    def from_base(cls, base_tv):
+        """Construct an `AndroidTVAsync` object from a `BaseTVAsync` object.
+
+        Parameters
+        ----------
+        base_tv : BaseTVAsync
+            The object that will be converted to an `AndroidTVAsync` object
+
+        Returns
+        -------
+        atv : AndroidTVAsync
+            The constructed `AndroidTVAsync` object
+
+        """
+        # pylint: disable=protected-access
+        atv = cls(
+            base_tv.host,
+            base_tv.port,
+            base_tv.adbkey,
+            base_tv.adb_server_ip,
+            base_tv.adb_server_port,
+            base_tv._state_detection_rules,
+        )
+        atv._adb = base_tv._adb
+        atv.device_properties = base_tv.device_properties
+        atv.installed_apps = base_tv.installed_apps
+        atv.max_volume = base_tv.max_volume
+        return atv
+
     # ======================================================================= #
     #                                                                         #
     #                          Home Assistant Update                          #

diff --git a/androidtv/androidtv/androidtv_sync.py b/androidtv/androidtv/androidtv_sync.py
@@ -50,6 +50,36 @@ def __init__(
         # fill in commands that can vary based on the device
         BaseAndroidTV._fill_in_commands(self)
 
+    @classmethod
+    def from_base(cls, base_tv):
+        """Construct an `AndroidTVSync` object from a `BaseTVSync` object.
+
+        Parameters
+        ----------
+        base_tv : BaseTVSync
+            The object that will be converted to an `AndroidTVSync` object
+
+        Returns
+        -------
+        atv : AndroidTVSync
+            The constructed `AndroidTVSync` object
+
+        """
+        # pylint: disable=protected-access
+        atv = cls(
+            base_tv.host,
+            base_tv.port,
+            base_tv.adbkey,
+            base_tv.adb_server_ip,
+            base_tv.adb_server_port,
+            base_tv._state_detection_rules,
+        )
+        atv._adb = base_tv._adb
+        atv.device_properties = base_tv.device_properties
+        atv.installed_apps = base_tv.installed_apps
+        atv.max_volume = base_tv.max_volume
+        return atv
+
     # ======================================================================= #
     #                                                                         #
     #                          Home Assistant Update                          #

diff --git a/androidtv/firetv/firetv_async.py b/androidtv/firetv/firetv_async.py
@@ -50,6 +50,36 @@ def __init__(
         # fill in commands that can vary based on the device
         BaseFireTV._fill_in_commands(self)
 
+    @classmethod
+    def from_base(cls, base_tv):
+        """Construct a `FireTVAsync` object from a `BaseTVAsync` object.
+
+        Parameters
+        ----------
+        base_tv : BaseTVAsync
+            The object that will be converted to a `FireTVAsync` object
+
+        Returns
+        -------
+        ftv : FireTVAsync
+            The constructed `FireTVAsync` object
+
+        """
+        # pylint: disable=protected-access
+        ftv = cls(
+            base_tv.host,
+            base_tv.port,
+            base_tv.adbkey,
+            base_tv.adb_server_ip,
+            base_tv.adb_server_port,
+            base_tv._state_detection_rules,
+        )
+        ftv._adb = base_tv._adb
+        ftv.device_properties = base_tv.device_properties
+        ftv.installed_apps = base_tv.installed_apps
+        ftv.max_volume = base_tv.max_volume
+        return ftv
+
     # ======================================================================= #
     #                                                                         #
     #                          Home Assistant Update                          #

diff --git a/androidtv/firetv/firetv_sync.py b/androidtv/firetv/firetv_sync.py
@@ -50,6 +50,36 @@ def __init__(
         # fill in commands that can vary based on the device
         BaseFireTV._fill_in_commands(self)
 
+    @classmethod
+    def from_base(cls, base_tv):
+        """Construct a `FireTVSync` object from a `BaseTVSync` object.
+
+        Parameters
+        ----------
+        base_tv : BaseTVSync
+            The object that will be converted to a `FireTVSync` object
+
+        Returns
+        -------
+        ftv : FireTVSync
+            The constructed `FireTVSync` object
+
+        """
+        # pylint: disable=protected-access
+        ftv = cls(
+            base_tv.host,
+            base_tv.port,
+            base_tv.adbkey,
+            base_tv.adb_server_ip,
+            base_tv.adb_server_port,
+            base_tv._state_detection_rules,
+        )
+        ftv._adb = base_tv._adb
+        ftv.device_properties = base_tv.device_properties
+        ftv.installed_apps = base_tv.installed_apps
+        ftv.max_volume = base_tv.max_volume
+        return ftv
+
     # ======================================================================= #
     #                                                                         #
     #                          Home Assistant Update                          #

diff --git a/androidtv/setup_async.py b/androidtv/setup_async.py
@@ -79,11 +79,11 @@ async def setup(
 
     # Fire TV
     if aftv.device_properties.get("manufacturer") == "Amazon":
-        aftv.__class__ = FireTVAsync
+        aftv = FireTVAsync.from_base(aftv)
 
     # Android TV
     else:
-        aftv.__class__ = AndroidTVAsync
+        aftv = AndroidTVAsync.from_base(aftv)
 
     # Fill in commands that are specific to the device
     aftv._fill_in_commands()  # pylint: disable=protected-access

diff --git a/tests/test_basetv_sync.py b/tests/test_basetv_sync.py
@@ -464,7 +464,7 @@ def test_get_device_properties(self):
             self.assertDictEqual({}, device_properties)
 
         with patchers.patch_shell(DEVICE_PROPERTIES_GOOGLE_TV)[self.PATCH_KEY]:
-            self.btv.__class__ = AndroidTVSync
+            self.btv = AndroidTVSync.from_base(self.btv)
             device_properties = self.btv.get_device_properties()
             self.assertEqual(self.btv.device_properties["manufacturer"], "Google")
             self.assertEqual(