Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable custom Audio State command #306

Merged
merged 13 commits into from Feb 18, 2022
Merged

Enable custom Audio State command #306

merged 13 commits into from Feb 18, 2022

Conversation

StephenGoodall
Copy link
Contributor

No description provided.

@StephenGoodall StephenGoodall marked this pull request as ready for review February 15, 2022 13:59
JeffLIrion
JeffLIrion reviewed Feb 15, 2022
View reviewed changes
androidtv/constants.py Outdated Show resolved Hide resolved
JeffLIrion
JeffLIrion reviewed Feb 15, 2022
View reviewed changes
androidtv/constants.py Outdated Show resolved Hide resolved
@JeffLIrion
Copy link
Owner

Please update this function's documentation so that it doesn't reference CMD_AUDIO_STATE:

python-androidtv/androidtv/basetv/basetv.py

Lines 470 to 476 in 813cfbf

def _audio_state(audio_state_response):
"""Parse the :meth:`audio_state` property from the output of the command :py:const:`androidtv.constants.CMD_AUDIO_STATE`.
Parameters
----------
audio_state_response : str, None
The output of the command :py:const:`androidtv.constants.CMD_AUDIO_STATE`

StephenGoodall and others added 3 commits February 18, 2022 11:12
@StephenGoodall
PR Suggestions (#1)
a110664 
* Reorder _cmd function

* Code suggestion change

* Code suggestion change

* Re-Ordering
@StephenGoodall
Update docs to refer to function
29bca23
@JeffLIrion
Update basetv.py
617750e
@StephenGoodall
Copy link
Contributor Author

Thanks Jeff, sorry I missed that occurrence!

@JeffLIrion JeffLIrion merged commit 4562db2 into JeffLIrion:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLIrion JeffLIrion JeffLIrion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StephenGoodall @JeffLIrion