Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HBO, Hulu, Peacock, and Paramount+ #328

Merged
merged 1 commit into from Jul 20, 2023

Conversation

sergeknystautas
Copy link
Contributor

While working on a different feature, I noticed several of my regular apps were not mapped to friendly names, so adding them.

@JeffLIrion
Copy link
Owner

This might lead to some edge case if a user configures com.hulu.livingroomplus to display as "Hulu" because both that and com.hulu.plus would display as "Hulu." But launching "Hulu" would open com.hulu.livingroomplus. I think it's OK, though.

https://github.com/home-assistant/core/blob/e3b81ad1701440b87c025ce5005027b396f51d81/homeassistant/components/androidtv/media_player.py#L283-L293

@sergeknystautas
Copy link
Contributor Author

This might lead to some edge case if a user configures com.hulu.livingroomplus to display as "Hulu" because both that and com.hulu.plus would display as "Hulu." But launching "Hulu" would open com.hulu.livingroomplus. I think it's OK, though.

https://github.com/home-assistant/core/blob/e3b81ad1701440b87c025ce5005027b396f51d81/homeassistant/components/androidtv/media_player.py#L283-L293

Gotcha, yeah I wasn't sure if the names had to be unique. I was adding the (2) suffix to the names that seemed like duplicate to avoid that, but maybe that's not necessary.

@JeffLIrion JeffLIrion merged commit f1272e0 into JeffLIrion:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants