Retry power command on error #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any tips on where to add extra tests to improve code coverage? |
|
I'd put it here: python-androidtv/tests/test_basetv_async.py Line 407 in 428e835 Also, please make the same changes in the non-async code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Nvidia Shield, power service can sometimes reply with "Failed to write while dumping service". When this happens, power state will be output as
None, even when device is turned on. This can cause Home Assistant to randomly switch playing -> standby -> playing momentarily.As a workaround, this PR attempts to detect the error and re-send the command when it happens.