Skip to content

The gilded rose refactoring kata ported to java 8, using Spock for Unit tests

License

Notifications You must be signed in to change notification settings

JeffQuandt/GildedRose_java

 
 

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

11 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

The Gilded Rose Code Kata

This is a Java version of the Gilded Rose Kata meant for Spock, original found here. Original Java version found here.

A few small changes

  • Migrating the unit tests to Spock as a learning exercise.
  • Clarifiying the Aged Brie aging rules
  • Include tests/support for Conjured items

Setup

This is setup as a Gradle project using the default src/main, etc. directory conventions. No IDE specific files will be provided, although I will be doing development in Intellij IDEA 2016.x.

Branches

  • The 'master' branch contains the starting point for the kata.

  • The 'solution-inheritanceFactory' branch is a solution for this kata using inheritance and Factory patterns. Feedback welcome!

  • The 'solution-delegate' branch is a solution using a delegate pattern.

Jeff

Original Description of the Gilded Rose

Hi and welcome to team Gilded Rose. As you know, we are a small inn with a prime location in a prominent city ran by a friendly innkeeper named Allison. We also buy and sell only the finest goods. Unfortunately, our goods are constantly degrading in quality as they approach their sell by date. We have a system in place that updates our inventory for us. It was developed by a no-nonsense type named Leeroy, who has moved on to new adventures. Your task is to add the new feature to our system so that we can begin selling a new category of items. First an introduction to our system:

  • All items have a SellIn value which denotes the number of days we have to sell the item
  • All items have a Quality value which denotes how valuable the item is
  • At the end of each day our system lowers both values for every item

Pretty simple, right? Well this is where it gets interesting:

  • Once the sell by date has passed, Quality degrades twice as fast
  • The Quality of an item is never negative
  • "Aged Brie" actually increases in Quality the older it gets. Once passed the sellIn, it increases twice as fast
  • The Quality of an item is never more than 50
  • "Sulfuras", being a legendary item, never has to be sold or decreases in Quality
  • "Backstage passes", like aged brie, increases in Quality as it's SellIn value approaches; Quality increases by 2 when there are 10 days or less and by 3 when there are 5 days or less but Quality drops to 0 after the concert

We have recently signed a supplier of conjured items. This requires an update to our system:

  • "Conjured" items degrade in Quality twice as fast as normal items

Feel free to make any changes to the UpdateQuality method and add any new code as long as everything still works correctly. However, do not alter the Item class or Items property as those belong to the goblin in the corner who will insta-rage and one-shot you as he doesn't believe in shared code ownership (you can make the UpdateQuality method and Items property static if you like, we'll cover for you). Subclasses or interfaces (and interface implementation-related changes in Item class) are acceptable as new code.

Just for clarification, an item can never have its Quality increase above 50, however "Sulfuras" is a legendary item and as such its Quality is 80 and it never alters.

About

The gilded rose refactoring kata ported to java 8, using Spock for Unit tests

Resources

License

Stars

Watchers

Forks

Packages

No packages published

Languages

  • Groovy 75.0%
  • Java 25.0%