Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart/Logging/Debug tweaks #18

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Restart/Logging/Debug tweaks #18

merged 4 commits into from
Feb 14, 2024

Conversation

slominskir
Copy link
Member

Watching log files and the web console after deploying version 1.17.0 revealed some issues:

  • On restart DBR can be null so instead of sending empty string just forward null.
  • There is a race condition in that javax.websocket.Session object will throw an Exception if you try to interrogate it after it is closed. This means on the debug screen if a client goes away right after the list of sessions is forwarded to the console and then the console calls methods on the session looking for ID, IP, User Agent, etc. then console crashes.
  • Some log message log levels need adjusting and session ID info needs to be included
  • Re-enable dropped message logging, but only log at thresholds to avoid flooding the log.

@slominskir slominskir marked this pull request as ready for review February 14, 2024 22:13
@slominskir slominskir merged commit 0dbbd26 into main Feb 14, 2024
1 check passed
@slominskir slominskir deleted the restart-tweaks branch February 14, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant