Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss677 - Layer 0/1 changes and 2019 trigger drivers #685

Merged
merged 40 commits into from Mar 31, 2020
Merged

Iss677 - Layer 0/1 changes and 2019 trigger drivers #685

merged 40 commits into from Mar 31, 2020

Conversation

omar-moreno
Copy link
Collaborator

No description provided.

omar-moreno and others added 30 commits January 21, 2020 23:24
@omar-moreno
Switch to using SiPixels to describe the electrodes for layers 0/1
6c60c47
@omar-moreno
SiStriplet class describing striplet electrodes.
689b923
@omar-moreno
Switch to using striplet electrodes.
fe661af
@omar-moreno
Add a hook to getUnmeasuredResolution to handle SiStriplets.
dcf02cd
@omar-moreno
Add method to retrieve row number, column number and strip center.
043c074
@omar-moreno
Add hooks to handle SiStriplet case.
c5391db
@tongtongcao
fix bugs for hodo gains and deadtime, and develop a driver for hodosc…
65d0f41 
…ope layer patterns
@tongtongcao
Fix a bug: threshold-crossing sampe is part of NSA instead of NSB; ch…
2678cdf 
…ange HodoscopePatternReadoutDriver.java: hodo patterns are added into data manageer only if there are hodo hits
@tongtongcao
move ecal-readout-sim/src/main/java/org/hps/readout/hodoscope/Hodosco…
2dc6337 
…pePattern.java -> record-util/src/main/java/org/hps/readout/util/HodoscopePattern.java
@tongtongcao
develop singles trigger driver for 2019 MC readout
dc85bbc
@omar-moreno
Fix sign flip bug.
df44f85
@tongtongcao
develop pairs trigger driver
2b3ca14
@omar-moreno
Fix typo
1428b85
@omar-moreno
Merge remote-tracking branch 'origin/iss655' into iss677
c43d6f5
@omar-moreno
Merge branch 'master' into iss677
ac6da26
@tongtongcao
add readout steering files: one is for singles trigger, and the other…
f5ee7da 
… is for pairs trigger
@tongtongcao
uncomment SVT driver in PhysicsRun2019TrigSingles.lcsim
dff9665
@omar-moreno
Change file name to make this the main recon driver for 2019 pass0
87e6b7e
@tongtongcao
add a steering file with pulse trigger and remove unnecessary drivers…
4b06d54 
… in the steering file with pairs trigger
@omar-moreno
Merge branch 'iss655' into iss677
9f7cead
@omar-moreno
Merge branch 'master' into iss677
a09e9c0
@omar-moreno
First pass of MC recon driver for 2019. Tracking is commented out for…
7b3ce5a 
… now.
@pbutti
Remove old flags from steering files
b1c1f12
@pbutti
Fix Typo
0cbbdcd
@pbutti
HelicalTrackHitDriver can retrieve the SiTrackerHit1DStrip as Tracker…
f38dffa 
…Hits. Useful for running on reco lcios
@omar-moreno
Class describing a 1D cluster. This class inherits the class in lcsim…
fc7d2e6 
… but overrides the getHitLength method so it's usable with SiStriplets.
@omar-moreno
Cast to the local definition of SiTrackerHitStrip1D.
87e4a3a
@omar-moreno
Remove debug.
50bfa04
@omar-moreno
Update steering file.
dd1e93a
@pbutti
Check on number of scattering planes to give the proper kalLayer to t…
5db0878 
…he SiModules
@omar-moreno omar-moreno added this to the V4.5 milestone Mar 30, 2020
normangraf
normangraf approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@normangraf normangraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests fine, so at least it doesn't break anything (that we're testing...). There are a LOT of changes in this request so I think we should continue performance testing after the merge.

@omar-moreno omar-moreno linked an issue Mar 31, 2020 that may be closed by this pull request
Validation 2019 Readout and Reconstruction Pipeline #677
Closed
@pbutti
Copy link
Contributor

pbutti commented Mar 31, 2020

I cannot speak much about all the trigger part. For the recon part things look ok. Only doubt is the current settings for the "firstLayer" in the KalmanPatRecHPS that is now set to "0", probably breaking 2016 proper pattern reco at the moment.

@cbravo135 cbravo135 merged commit 01442f7 into master Mar 31, 2020
@normangraf
Copy link
Contributor

Layering starts at 1.

@pbutti
Copy link
Contributor

pbutti commented Mar 31, 2020 •
edited

It's a different numbering what I'm talking about.
In the KF pat reco, numbering starts at 0 and ends to 13.

@omar-moreno omar-moreno mentioned this pull request Jun 30, 2020
Closed
@JeremyMcCormick JeremyMcCormick modified the milestones: V4.5, v5.0 Feb 25, 2021
@normangraf normangraf mentioned this pull request Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normangraf normangraf normangraf approved these changes

@pbutti pbutti pbutti approved these changes

@tongtongcao tongtongcao Awaiting requested review from tongtongcao

@bloodyyugo bloodyyugo Awaiting requested review from bloodyyugo

@mccaky mccaky Awaiting requested review from mccaky

Assignees

@omar-moreno omar-moreno

@tongtongcao tongtongcao

@pbutti pbutti

Labels
critical enhancement
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.

Validation 2019 Readout and Reconstruction Pipeline
6 participants
@omar-moreno @pbutti @normangraf @cbravo135 @JeremyMcCormick @tongtongcao