Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable names in configuration files #19

Closed
kpaschke opened this issue Aug 10, 2018 · 2 comments
Closed

Update variable names in configuration files #19

kpaschke opened this issue Aug 10, 2018 · 2 comments

Comments

@kpaschke
Copy link
Collaborator

Define a template style to keep names roughly consistent, but keep names short.

@paulmking
Copy link
Collaborator

This is related to issue #22

@paulmking
Copy link
Collaborator

Most device names have been updated in their respective map files. Maybe we need more documentation on what the style is, but we have a style now.

hansenjo pushed a commit to hansenjo/japan that referenced this issue Jul 22, 2024
* Added a new set of mock-data parameter files for the Hall A beamline,
and increased the maximum size of the ROOT branch vector.

The mock_moller_beamline* map files have the device names and locations
for the Hall A beamline elements based on MOLLER DocDB 1071-v5.

This increased the number of variables in the root files, and we needed
to increase the maximum size of the ROOT branch vector to avoid run-time
errors.

The standard mock data detector map and the mock data parameter file
have been changed to match.

* Changed the mock data injector beamline channel gains from 1 to ~76e-6.

This is to make sure the mock data values are a better match to what we
would expect.

NOTE:  this is still using the VQWK-era ADC gain value, and we should
determine what the updated value ought to be for the MOLLER ADCs and
change it throughout the mapfiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants