Merge develop into master for bugfix version #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-forward develop to master (no actual operations on develop)
Due to a sign error, the events were generated around +4587 mm instead of around -4587 mm. The call to GetFrameTranslation should have been a call to GetTranslation, or various equivalent sign changes. This was not a problem before since the target was centered at zero, and so -0 is the same...
/remoll/magcurrent -> /remoll/field/current Previous versions didn't work anymore since now Geant4 tokenizes arguments on spaces and only the first one (field name) was passed. Now passing also second one. No unit since only two arguments are supported by G4AnyMethod.
Value entered in meters since, again, no third token for units is allowed.
This will cause the old magnetic fields to be read in correctly, even if there is no /remoll/field/zoffset command
Bugfix: Messenger for field z offsets
…nstream-of-pivot Bugfix: Fix event generator to be in the target, not downstream (MAJOR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.