TAC hits #899
TAC hits #899
Conversation
…lationTable , DTACHit_factory, DFactoryGenerator to integrate the TAC Digi classes. Added a class to DApplication to allow safe mutex locking without getting stuck on exceptions. At this time there is only one single class TAC with no distinction if it is the lead glass or some other, it uses the tranlation table entries with label/table TAC. DTACHit class has not been tested yet
…ss that knows how to rebuild TAC hits from raw FADC data. Added TAC to GlueX.h file. Added files to protect locking in DANA
…d using fits with two differnt functors that can be set as templates. Checked that I get decent result using all methods for TAC ADC time
|
Let me kick off the automated test for this branch... |
|
Build status for this pull request: FAILURE Build log: /work/halld/pull_request_test/sim-recon^tac_hits-0/make_tac_hits-0.log |
|
I see - this PR is created from Hovanes' fork of this repo. I forget if we decided to support this case. Let me take a look... |
|
Build status for this pull request: FAILURE Build log: /work/halld/pull_request_test/sim-recon^tac_hits-0/make_tac_hits-0.log |
3 similar comments
|
Build status for this pull request: FAILURE Build log: /work/halld/pull_request_test/sim-recon^tac_hits-0/make_tac_hits-0.log |
|
Build status for this pull request: FAILURE Build log: /work/halld/pull_request_test/sim-recon^tac_hits-0/make_tac_hits-0.log |
|
Build status for this pull request: FAILURE Build log: /work/halld/pull_request_test/sim-recon^tac_hits-0/make_tac_hits-0.log |
|
OK, needed to make a couple bug fixes. As a reminder, we don't run the automated tests on forked repos due to security concerns. So I'll merge these changes and watch the nightly build to confirm that we still build properly. |
|
Thanks for checking and merging it.I probably will use a branch on the mainGluex repository instead of forking next time. Hovanes
Sent via the Samsung Galaxy Note® 4, an AT&T 4G LTE smartphone
…-------- Original message --------
From: Sean Dobbs <notifications@github.com>
Date: 8/24/17 6:16 PM (GMT-05:00)
To: JeffersonLab/sim-recon <sim-recon@noreply.github.com>
Cc: Hovanes <hovanes.egiyan@gmail.com>, Author <author@noreply.github.com>
Subject: Re: [JeffersonLab/sim-recon] TAC hits (#899)
OK, needed to make a couple bug fixes.
As a reminder, we don't run the automated tests on forked repos due to security concerns. So I'll merge these changes and watch the nightly build to confirm that we still build properly.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/JeffersonLab/sim-recon","title":"JeffersonLab/sim-recon","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/JeffersonLab/sim-recon"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sdobbs in #899: OK, needed to make a couple bug fixes.\r\n\r\nAs a reminder, we don't run the automated tests on forked repos due to security concerns. So I'll merge these changes and watch the nightly build to confirm that we still build properly."}],"action":{"name":"View Pull Request","url":"#899 (comment)"}}}
|
![https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open](https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open){kind=link}
Added a sim-recon library to generate TAC hits for PS normalization/calibration runs for online monitoring.