Fixed relationships not being namespaced when needed #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before creating a relationship it does a check to see if the main class is namespaced, and if so, appends the namespace to relationship, otherwise it leaves it as is.
|
Thanks! Sorry it took so long. Been super busy. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a relationship it does a check to see if the main class is namespaced, and if so, appends the namespace to relationship, otherwise it leaves it as is.
Really sorry as I have no idea how to attach a pull request to an existing issue. The issue is described as here: #7
This fixes it from what I can tell (my tests now work as they failed before) and your tests all run green still.
Hope that helps :-)