Skip to content

Commit

Permalink
SDK - Moved some data from the component_ref annotation to the compon…
Browse files Browse the repository at this point in the history
…ent_spec annotation (kubeflow#3751)

Removing the component spec from component_ref (since it would be a duplicate), but making sure the whole spec if available in component_spec.
  • Loading branch information
Ark-kun authored and Jeffwan committed Dec 9, 2020
1 parent 048dcef commit ffaf1e2
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions sdk/python/kfp/dsl/_component_bridge.py
Expand Up @@ -59,9 +59,10 @@ def _create_container_op_from_component_and_arguments(
)

component_meta = copy.copy(component_spec)
component_meta.implementation = None
task._set_metadata(component_meta)
task._component_ref = component_ref
component_ref_without_spec = copy.copy(component_ref)
component_ref_without_spec.spec = None
task._component_ref = component_ref_without_spec

# Previously, ContainerOp had strict requirements for the output names, so we had to
# convert all the names before passing them to the ContainerOp constructor.
Expand Down

0 comments on commit ffaf1e2

Please sign in to comment.