Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a grey fence that conducts electricity #180

Closed
wants to merge 10 commits into from
Closed

Added a grey fence that conducts electricity #180

wants to merge 10 commits into from

Conversation

Megaf
Copy link

@Megaf Megaf commented Sep 18, 2014

Hi, I just added a grey fence that is able to conduct mese signals.
I've done that because we like to use fences to build lamp posts and it would be so much better if fences could conduct electricity.

Also, the conducting fence is a good alternative to vertical mese wires.

@HybridDog
Copy link
Contributor

I like it but I don't think that the textures fit yet.
mesecons is usually yellow, so I made little yellow stripes for the electricfence_tile.png texture:

enabled:
electricfence_tile_active

disabled:
electricfence_tile_inactive

@donat-b
Copy link

donat-b commented Oct 25, 2014

@HybridDog can you make a screenshot?

advpng and optipng
@HybridDog
Copy link
Contributor

ok
the stripes should show that mesecons wire is mixed into the fence

without stripes:
screenshot_1215343263

with stripes:
screenshot_1215077041

comparison:
https://github.com/Megaf/minetest-mod-mesecons/pull/1/files

add stripes (pull request mainly made for comparison this time)
@Jeija
Copy link
Collaborator

Jeija commented Nov 22, 2014

Nice, but there are already sooo many things in mesecons, I actually don't want even more stuff in there. You may provide the fence as an extension to the main mod.

@Jeija Jeija closed this Nov 22, 2014
@Megaf
Copy link
Author

Megaf commented Nov 22, 2014

The code needs revision and my need improvements too. Just be aware of that.
It is stable and I do use it on my server, it is perfect and I beleve it could be even better.

@Jeija
Copy link
Collaborator

Jeija commented Nov 22, 2014

If there is enough public support for this idea and if you can maintain the fence code in the future, I'm not opposed to merging this. It's just... why would you need a fence that conducts logic signals? Do you have some usecase / screenshots / ..? If so, sure you can merge this.

@Jeija Jeija reopened this Nov 22, 2014
@Megaf
Copy link
Author

Megaf commented Nov 22, 2014

I will close this pull request, rework the addon and add it as an extension. Publishing screenshots, Im sure you will like.

@Megaf Megaf closed this Nov 22, 2014
@HybridDog
Copy link
Contributor

You could make a mod for it. I would use the mod to make mesecons light block lamps.

@Megaf
Copy link
Author

Megaf commented Nov 23, 2014

@Jeija Here you are, several screenshots of use cases for Mese Fences. http://www.zimagez.com/galerie/Mese-Fences-32852-0.php

@Megaf Megaf mentioned this pull request Nov 23, 2014
@Megaf
Copy link
Author

Megaf commented Nov 25, 2014

@HybridDog @donat-b I moved conducting fences to it's own mod. It's now on https://github.com/Megaf/mese_fence

So please use the latest mesecons mod from Jeija and my mese_fence.

@HybridDog
Copy link
Contributor

I already cloned it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants