Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to automatically accept matchups #32

Open
LianhaoXue opened this issue Apr 22, 2022 · 4 comments
Open

Unable to automatically accept matchups #32

LianhaoXue opened this issue Apr 22, 2022 · 4 comments

Comments

@LianhaoXue
Copy link

PZ@Z 2X%HVS% )I7Z~66TU0
/lol-matchmaking/v1/ready-check/accept --> This API should use the HTTP2 protocol

@musicderp
Copy link
Collaborator

Could I get your full logs as well as the region you're on?
If http2 is actually what's needed to make these calls, it will require a massive rewrite of willump, as that is what handles talking to the LCU and I don't think aiohttp supports this.

@LianhaoXue
Copy link
Author

LianhaoXue commented Apr 23, 2022 via email

@LianhaoXue
Copy link
Author

image
This is logs.

@Jellayy
Copy link
Owner

Jellayy commented Apr 23, 2022

Honestly something I never thought to test for. I wonder how many other regions are on HTTP2 or if it's localized to China. I assume much like us, Willump was only tested in NA.

If you're interested in rewriting a version for HTTP2, eventually we want to move away from Willump entirely and that might make it easier when that happens. It was great to use while still figuring out how the LCU API worked, but it does some things really weird and we want to move to either using lcu-driver or interfacing with the LCU API exclusively on our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants