Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-export traits together with the derive #271

Closed
JelteF opened this issue Jul 3, 2023 · 3 comments · Fixed by #273
Closed

re-export traits together with the derive #271

JelteF opened this issue Jul 3, 2023 · 3 comments · Fixed by #273
Assignees
@JelteF
Milestone
1.0.0

Comments

@JelteF
Copy link
Owner

JelteF commented Jul 3, 2023

This seems quite nice for traits that are not in the prelude. Often if you're deriving things you also want to use them.
@JelteF JelteF added this to the 1.0.0 milestone Jul 3, 2023
@JelteF JelteF mentioned this issue Jul 15, 2023
Merged
@JelteF
Copy link
Owner Author

JelteF commented Jul 15, 2023

Sadly this is not easy to do without opening ourselves up to unfixable breakage if Rust decides to add some derives for these traits too. This showed up already for the Debug trait. See #273 for details.

@JelteF
Copy link
Owner Author

JelteF commented Jul 15, 2023

So removing this from the 1.0.0 milestone.

@JelteF JelteF removed this from the 1.0.0 milestone Jul 15, 2023
@JelteF
Copy link
Owner Author

JelteF commented Jul 15, 2023

Blocked by trait aliases rust-lang/rust#41517

@tyranron tyranron added this to the 1.0.0 milestone Jul 20, 2023
JelteF added a commit that referenced this issue Jul 23, 2023
@JelteF @tyranron
Re-export traits (#273)
e10b96b 
Re-export traits from `std` for all our derives. This way people don't
need to import traits manually when they want to reference them
somewhere, such as bounds.

Fixes #271

---------

Co-authored-by: tyranron <tyranron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JelteF JelteF

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Re-export traits JelteF/derive_more
2 participants
@JelteF @tyranron