Fix ?Sized
type parameters in Debug
#289
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synopsis
At the moment,
derive_more::Debug
fails to work with?Sized
generics:And generates the following error:
At the same moment,
std::Debug
works OK:If we look at its expansion:
We can see that
std::Debug
always uses fields as&&self.0
, while we in ourderive_more::Debug
expansion use&self.0
only.Solution
Simply use double-ref in the expansion, as the error suggests, and
std::Debug
does.Checklist
Documentation is updated(not required)CHANGELOG entry is added(not required)