forked from pgbouncer/pgbouncer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support replication connections through PgBouncer
In session pooling mode PgBouncer is pretty much a transparent proxy,
i.e. the client does normally not even need to know that PgBouncer is in
the middle. This allows things like load balancing and failovers without
the client needing to know about this at all. But as soon as replication
connections are needed, this was not possible anymore, because PgBouncer
would reject those instead of proxying them to the right server.
This PR fixes that by also proxying replication connections. They are
handled pretty differently from normal connections though. A client and
server replication connection will form a strong pair, as soon as one is
closed the other is closed too. So, there's no caching of the server
replication connections, like is done for regular connections. This
seems like a good tradeoff for ease of implementation, because
TODO:
- [ ] Implement hba support for replication database. The current
version allows PgBouncer allows any user that can authenticate to
also open a physical replication connection. Normally Postgres
requires a replication database entry in the hba file for this.
Obviously this is still checked by postgres, but if a hardcoded user
is used for the connection this might still be problematic.
- [ ] tests with `pg_recvlogical`, `pg_receivewal` and `pg_basebackup`
- [ ] tests over SSL
Fixes pgbouncer#382- Loading branch information
Showing
17 changed files
with
447 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /*------------------------------------------------------------------------- | ||
| * | ||
| * builtins.h | ||
| * Declarations for operations on built-in types. | ||
| * | ||
| * | ||
| * Portions Copyright (c) 1996-2023, PostgreSQL Global Development Group | ||
| * Portions Copyright (c) 1994, Regents of the University of California | ||
| * | ||
| * include/common/builtins.h | ||
| * | ||
| *------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| /* bool.c */ | ||
| extern bool parse_bool(const char *value, bool *result); | ||
| extern bool parse_bool_with_len(const char *value, size_t len, bool *result); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /*------------------------------------------------------------------------- | ||
| * | ||
| * bool.c | ||
| * Functions for the built-in type "bool". | ||
| * | ||
| * Portions Copyright (c) 1996-2023, PostgreSQL Global Development Group | ||
| * Portions Copyright (c) 1994, Regents of the University of California | ||
| * | ||
| * | ||
| * IDENTIFICATION | ||
| * src/backend/utils/adt/bool.c | ||
| * | ||
| *------------------------------------------------------------------------- | ||
| */ | ||
|
|
||
| #include "common/postgres_compat.h" | ||
|
|
||
| /* | ||
| * Try to interpret value as boolean value. Valid values are: true, | ||
| * false, yes, no, on, off, 1, 0; as well as unique prefixes thereof. | ||
| * If the string parses okay, return true, else false. | ||
| * If okay and result is not NULL, return the value in *result. | ||
| */ | ||
| bool | ||
| parse_bool(const char *value, bool *result) | ||
| { | ||
| return parse_bool_with_len(value, strlen(value), result); | ||
| } | ||
|
|
||
| bool | ||
| parse_bool_with_len(const char *value, size_t len, bool *result) | ||
| { | ||
| switch (*value) | ||
| { | ||
| case 't': | ||
| case 'T': | ||
| if (pg_strncasecmp(value, "true", len) == 0) | ||
| { | ||
| if (result) | ||
| *result = true; | ||
| return true; | ||
| } | ||
| break; | ||
| case 'f': | ||
| case 'F': | ||
| if (pg_strncasecmp(value, "false", len) == 0) | ||
| { | ||
| if (result) | ||
| *result = false; | ||
| return true; | ||
| } | ||
| break; | ||
| case 'y': | ||
| case 'Y': | ||
| if (pg_strncasecmp(value, "yes", len) == 0) | ||
| { | ||
| if (result) | ||
| *result = true; | ||
| return true; | ||
| } | ||
| break; | ||
| case 'n': | ||
| case 'N': | ||
| if (pg_strncasecmp(value, "no", len) == 0) | ||
| { | ||
| if (result) | ||
| *result = false; | ||
| return true; | ||
| } | ||
| break; | ||
| case 'o': | ||
| case 'O': | ||
| /* 'o' is not unique enough */ | ||
| if (pg_strncasecmp(value, "on", (len > 2 ? len : 2)) == 0) | ||
| { | ||
| if (result) | ||
| *result = true; | ||
| return true; | ||
| } | ||
| else if (pg_strncasecmp(value, "off", (len > 2 ? len : 2)) == 0) | ||
| { | ||
| if (result) | ||
| *result = false; | ||
| return true; | ||
| } | ||
| break; | ||
| case '1': | ||
| if (len == 1) | ||
| { | ||
| if (result) | ||
| *result = true; | ||
| return true; | ||
| } | ||
| break; | ||
| case '0': | ||
| if (len == 1) | ||
| { | ||
| if (result) | ||
| *result = false; | ||
| return true; | ||
| } | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
|
|
||
| if (result) | ||
| *result = false; /* suppress compiler warning */ | ||
| return false; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.