Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to work with Go 1.16 Alpine image #8

Merged
merged 1 commit into from Feb 11, 2021

Conversation

FnTm
Copy link
Contributor

@FnTm FnTm commented Feb 11, 2021

I tried to run this today, and it looks like the required go version hasn't made it to a point where the docker image label points to it. This had broken Docker image.
Got this error:

package embed is not in GOROOT (/usr/local/go/src/embed)

This is probably a super temporary fix, and may just be ok to leave this PR open in case anyone else looks at why this is not building for them.

This should be updated to a non-rc version after one is released
@mkonda mkonda merged commit 47a6fa9 into Jemurai:master Feb 11, 2021
@mkonda
Copy link
Member

mkonda commented Feb 11, 2021

Thanks!
I am taking a separate task to both review this again when it is final and to figure out how to better test the docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants