New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[♻️ Refactor] 객관적인 퍼포먼스 비교를 위해 메타볼 애니메이션 OOP로 재설계한다. #37
Merged
Commits on Mar 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 522fdc4 - Browse repository at this point
Copy the full SHA 522fdc4View commit details -
- 클래스 문법에 있어서 과하다 싶은 룰들을 제거했다. - 또한, no-shadow와 unused-vars는 타입스크립트 lint에서 걸러주는 방식으로 해결했다.
Configuration menu - View commit details
-
Copy full SHA for 062593f - Browse repository at this point
Copy the full SHA 062593fView commit details
Commits on Mar 23, 2023
-
- 일단 메타볼 애니메이션을 관장하는 데 있어, 해당 클래스가 아닌 다른 외부의 관련된 어떤 것을 바꿀 수도 있다.- 이를 퍼사드 패턴을 이용하여 좀 더 캔버스의 손상 없이 자유롭게 추가할 수 있도록 하였다. - 캔버스의 경우 Canvas 엘리먼트도 있겠지만, 해당 바깥 배경이 Gradient인 Canvas도 존재한다. - 이러한 케이스에 따라 좀 더 입맛에 맞게 핸들링할 수 있도록 options를 추가했다.
Configuration menu - View commit details
-
Copy full SHA for 918a5ad - Browse repository at this point
Copy the full SHA 918a5adView commit details -
Configuration menu - View commit details
-
Copy full SHA for b24089b - Browse repository at this point
Copy the full SHA b24089bView commit details
Commits on Mar 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1b64f21 - Browse repository at this point
Copy the full SHA 1b64f21View commit details -
✨ create Animation subject, observers
- 옵저버 패턴을 적용하여 상태 변경에 대한 업데이트 로직에 대해 각 객체들을 느슨하게 결합하였습니다.
Configuration menu - View commit details
-
Copy full SHA for 1ba731a - Browse repository at this point
Copy the full SHA 1ba731aView commit details -
♻️ refactor codes for initializing metaballs
- 생성 과정에 있어서 누락된 property initializaion을 추가했다. (ex: Obserer - key) - 헷갈리지 않도록 현재 로직에서 불필요한 코드(ex: moveStrategy)들을 제거했다.
Configuration menu - View commit details
-
Copy full SHA for c699507 - Browse repository at this point
Copy the full SHA c699507View commit details -
✨ animate MetaballCanvas by App facade
- 초기화할 시점에서 canvas 역시 모델과 독립할 필요가 있다고 생각했다. 고로 분리했다. - 이후 App에서 초기에 initialize를 수행한다.
Configuration menu - View commit details
-
Copy full SHA for c7eaa42 - Browse repository at this point
Copy the full SHA c7eaa42View commit details
Commits on Mar 25, 2023
-
✨ create metaball move strategy
- 전략 패턴을 이용하여 move 전략을 유연하게 바꿀 수 있도록 하였다.
Configuration menu - View commit details
-
Copy full SHA for b74cc4a - Browse repository at this point
Copy the full SHA b74cc4aView commit details
Commits on Mar 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f412823 - Browse repository at this point
Copy the full SHA f412823View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0204ad4 - Browse repository at this point
Copy the full SHA 0204ad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d8d5cd - Browse repository at this point
Copy the full SHA 5d8d5cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22767a2 - Browse repository at this point
Copy the full SHA 22767a2View commit details
Commits on Mar 28, 2023
-
- 전체 픽셀이 아닌 두 원만 비교함으로써 최적화를 달성했다. - 스크립트에 대한 계산 비용을 약 50배 최적화시켰다.
Configuration menu - View commit details
-
Copy full SHA for 92b15f9 - Browse repository at this point
Copy the full SHA 92b15f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74025a9 - Browse repository at this point
Copy the full SHA 74025a9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.