Feature cars contents #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* content type can be changed * if changing to another type, the car will be filled up * if changing to empty, the car will be emptied * content amount can be changed * only for cars that have a content type * cars are distinguished by their type and each first line of number and name (this is to not clutter the list) * inputs cannot exceed what is possible ingame Not done in this version: * shortcut buttons Obsolete (as in I won't work on this): * shortcuts for filling and emptying, as filling can be done by changing to another type then back and emptying by switching type to empty Changes: * moved everything rolling stock related except the menu itself into its own file
* content type can be changed * if changing to another type, the car will be filled up * if changing to empty, the car will be emptied * content amount can be changed * only for cars that have a content type * cars are distinguished by their type and each first line of number and name (this is to not clutter the list) * inputs cannot exceed what is possible ingame Not done in this version: * shortcut buttons Obsolete (as in I won't work on this): * shortcuts for filling and emptying, as filling can be done by changing to another type then back and emptying by switching type to empty Changes: * moved everything rolling stock related except the menu itself into its own file
* content type can be changed * if changing to another type, the car will be filled up * if changing to empty, the car will be emptied * content amount can be changed * only for cars that have a content type * cars are distinguished by their type and each first line of number and name (this is to not clutter the list) * inputs cannot exceed what is possible ingame Not done in this version: * shortcut buttons Obsolete (as in I won't work on this): * shortcuts for filling and emptying, as filling can be done by changing to another type then back and emptying by switching type to empty Changes: * moved everything rolling stock related except the menu itself into its own file
JennyKmu
approved these changes
Nov 5, 2021
There was a problem hiding this comment.
Perfect !
In the future, Readme.md will be updated only right before the merge back to main branch for release. Header update in the main.py (version, contributors...) as well.
Maybe split PEP conformity pull requests from feature requests (easier to review and track down modifications)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
Not done in this version:
Decided to not do before GUI:
Closes #8
Changes: