Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

[FEATURE] Auto-Save #121

Closed
jordan-dalby opened this issue Nov 18, 2023 · 1 comment · Fixed by #124
Closed

[FEATURE] Auto-Save #121

jordan-dalby opened this issue Nov 18, 2023 · 1 comment · Fixed by #124
Labels
enhancement New feature or request

Comments

@jordan-dalby
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Servers currently do not automatically save.

Describe the solution you'd like
An auto-save feature, configurable.

Describe alternatives you've considered
Data backups (which should also be added as part of another ticket)

Additional context
n/a

@jordan-dalby jordan-dalby added the enhancement New feature or request label Nov 18, 2023
jordan-dalby pushed a commit to jordan-dalby/ArkAscendedServerManager that referenced this issue Nov 18, 2023
This commit adds auto-saving functionality. This feature can
be enabled / disabled, with a
configurable interval.
jordan-dalby pushed a commit to jordan-dalby/ArkAscendedServerManager that referenced this issue Nov 18, 2023
This commit adds auto-saving functionality. This feature can
be enabled / disabled, with a
configurable interval.
JensvandeWiel pushed a commit that referenced this issue Nov 18, 2023
This commit adds auto-saving functionality. This feature can
be enabled / disabled, with a
configurable interval.

Co-authored-by: Jordan Dalby <jordan.dalby@outlook.com>
@JensvandeWiel
Copy link
Owner

@jordan-dalby found an issue, when i enable auto save it's default value is 0 and you can not divide by zero :)
panic: runtime error: integer divide by zero

goroutine 38 [running]:
github.com/JensvandeWiel/ArkAscendedServerManager/server.(*ServerController).AutoSaveServers(0xc00006f080)
C:/Users/Jens van de Wiel/MyProjects/ArkAscendedServerManager/server/server_controller.go:124 +0x488
github.com/JensvandeWiel/ArkAscendedServerManager/server.(*ServerController).RunAutoSaveTimers(0xc00006f080)
C:/Users/Jens van de Wiel/MyProjects/ArkAscendedServerManager/server/server_controller.go:97 +0x5f
github.com/JensvandeWiel/ArkAscendedServerManager/server.(*ServerController).Startup(0xc00006f080, {0xe64190, 0xc00020bef0})
C:/Users/Jens van de Wiel/MyProjects/ArkAscendedServerManager/server/server_controller.go:63 +0x305
main.main.func1({0xe64190, 0xc00020bef0})
C:/Users/Jens van de Wiel/MyProjects/ArkAscendedServerManager/main.go:64 +0xae
github.com/wailsapp/wails/v2/internal/frontend/desktop/windows.(*Frontend).Run.func3()
C:/Users/Jens van de Wiel/go/pkg/mod/github.com/wailsapp/wails/v2@v2.6.0/internal/frontend/desktop/windows/frontend.go:191 +0x57
created by github.com/wailsapp/wails/v2/internal/frontend/desktop/windows.(*Frontend).Run in goroutine 1
C:/Users/Jens van de Wiel/go/pkg/mod/github.com/wailsapp/wails/v2@v2.6.0/internal/frontend/desktop/windows/frontend.go:189 +0x3a5

jordan-dalby pushed a commit to jordan-dalby/ArkAscendedServerManager that referenced this issue Nov 18, 2023
This PR fixes auto-save divide by 0
error.
jordan-dalby pushed a commit to jordan-dalby/ArkAscendedServerManager that referenced this issue Nov 18, 2023
    This PR fixes auto-save divide by 0 error.
@JensvandeWiel JensvandeWiel linked a pull request Nov 18, 2023 that will close this issue
JensvandeWiel added a commit that referenced this issue Nov 18, 2023
* #121: Fix auto-save
    This PR fixes auto-save divide by 0 error.

* Moved check & assigned to default value if <=0

---------

Co-authored-by: Jordan Dalby <jordan.dalby@outlook.com>
Co-authored-by: Jens van de Wiel <85284773+JensvandeWiel@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants