Merge pull request #52 from JenswBE/jw/use-common-linting-config

Use common linting config

.github/workflows/test-build-publish.yml

@@ -35,16 +35,14 @@ jobs:
           check-latest: true
           go-version: ${{ env.GO_VERSION }}
 
+      - name: Pull common linter configs
+        run: wget -O .golangci.yml https://raw.githubusercontent.com/JenswBE/setup/main/programming_configs/golang/.golangci.yml
+
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
           version: latest
 
-      - name: Run exhaustive
-        run: |
-          go install github.com/nishanths/exhaustive/...@latest
-          exhaustive ./...
-
       - name: Start E2E services
         working-directory: e2e
         run: |

internal/manager.go

@@ -143,27 +143,30 @@ func (m *Manager) Run(ctx context.Context, c *config.Config) map[string]report.R
 }
 
 func pingHealthCheckURL(ctx context.Context, u *url.URL) {
-	if u != nil {
-		// Create request
-		logger := log.With().Str("health_check_url", u.String()).Logger()
-		req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
-		if err != nil {
-			logger.Error().Err(err).Msg("Failed to create request for health check URL")
-			return
-		}
+	// Skip if URL is nil
+	if u == nil {
+		return
+	}
 
-		// Call health check
-		resp, err := http.DefaultClient.Do(req)
-		if err != nil {
-			logger.Error().Err(err).Msg("Failed to send GET request to health check URL")
-			return
-		}
+	// Create request
+	logger := log.With().Str("health_check_url", u.String()).Logger()
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil)
+	if err != nil {
+		logger.Error().Err(err).Msg("Failed to create request for health check URL")
+		return
+	}
 
-		// Close body
-		if resp != nil {
-			if err = resp.Body.Close(); err != nil {
-				log.Error().Err(err).Msg("Failed to close response body after calling health check URL")
-			}
+	// Call health check
+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		logger.Error().Err(err).Msg("Failed to send GET request to health check URL")
+		return
+	}
+
+	// Close body
+	if resp != nil {
+		if err = resp.Body.Close(); err != nil {
+			log.Error().Err(err).Msg("Failed to close response body after calling health check URL")
 		}
 	}
 }

lint.sh

@@ -0,0 +1,3 @@
+# This script is intended to be sourced like "source lint.sh" or ". lint.sh".
+# Config is available at https://raw.githubusercontent.com/JenswBE/setup/main/programming_configs/golang/.golangci.yml
+golangci-lint run -c ../setup/programming_configs/golang/.golangci.yml