WIP

.github/workflows/test.yml

@@ -4,16 +4,22 @@ on:
   push:
   pull_request:
 
+env:
+  GO_VERSION: "1.22" # Keep version aligned with server/files/network-performance-file-generator/Dockerfile
+  PYTHON_VERSION: "3.11" # Debian 12
+
 jobs:
-  lineinfile:
-    name: Test lineinfile
+  python-tests:
+    name: Test Python code
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout repo
+        uses: actions/checkout@v4
 
-      - uses: actions/setup-python@v5
+      - name: Setup Python
+        uses: actions/setup-python@v5
         with:
-          python-version: "3.10" # Ubuntu 22.04
+          python-version: ${{ env.PYTHON_VERSION }}
 
       - name: Run unit tests for desktop/lineinfile
         working-directory: desktop/lineinfile
@@ -22,3 +28,30 @@ jobs:
       - name: Run unit tests for server/templates/nut/client_server/upssched-cmd
         working-directory: server/templates/nut/client_server/upssched-cmd
         run: python3 -m unittest
+
+  golang-tests:
+    name: Test Golang code
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v4
+
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          check-latest: true
+          go-version: ${{ env.GO_VERSION }}
+
+      - name: Pull common linter configs
+        run: wget -O .golangci.yml https://raw.githubusercontent.com/JenswBE/setup/main/programming_configs/golang/.golangci.yml
+
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v6
+        working-directory: server/files/network-performance-file-generator
+        with:
+          version: latest
+          args: --timeout=5m
+
+      - name: Run unit tests
+        working-directory: server/files/network-performance-file-generator
+        run: go test main.go main_test.go

server/files/network-performance-file-generator/Dockerfile

@@ -1,3 +1,4 @@
+# Keep version aligned with .github/workflows/test.yml
 FROM docker.io/library/golang:1.22 AS builder
 WORKDIR /src/
 COPY main.go main.go

server/files/network-performance-file-generator/main.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"flag"
 	"fmt"
+	"io"
 	"log/slog"
 	"net/http"
 	"os"
@@ -13,6 +14,7 @@ import (
 const Port = "8080"
 const SizeMBParam = "size_mb"
 const DefaultSizeMB = 10
+const MB = 1024 * 1024 // 1MB
 
 func main() {
 	// Flags
@@ -28,8 +30,15 @@ func main() {
 		}
 	}
 
+	// Run service
+	if err := run(); err != nil {
+		slog.Error("Starting service returned error", "error", err)
+	}
+}
+
+func run() error {
 	// Init
-	payload1MB := bytes.Repeat([]byte("X"), 1024*1024)
+	payload1MB := bytes.Repeat([]byte("X"), MB)
 
 	// Start server
 	slog.Info("Starting server ...", "port", Port)
@@ -55,7 +64,7 @@ func main() {
 			}
 		}
 	}))
-	slog.Error("Failed to start HTTP server", "error", err)
+	return fmt.Errorf("failed to start HTTP server: %w", err)
 }
 
 func parseSizeParam(input string, defaultValue int) (int, error) {
@@ -81,9 +90,30 @@ func isHealthy() bool {
 	checkURL := fmt.Sprintf("http://localhost:%s?%s=2", Port, SizeMBParam)
 	resp, err := http.Get(checkURL)
 	if err != nil {
-		slog.Warn("Http call returned error", "error", err)
+		slog.Warn("Healthcheck: HTTP call returned error", "error", err)
+		return false
+	}
+	defer func() {
+		if closeErr := resp.Body.Close(); closeErr != nil {
+			slog.Warn("Healthcheck: Failed to close body", "error", closeErr)
+		}
+	}()
+
+	if resp.ContentLength != 2*MB {
+		slog.Warn("Healthcheck: HTTP call returned incorrect content length", "expected", 2048, "actual", resp.ContentLength)
+		return false
+	}
+
+	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		slog.Warn("Healthcheck: Failed to read response body")
+		return false
+	}
+	if len(body) != 2*MB {
+		slog.Warn("Healthcheck: Actual response body has different length from ContentLength", "content_length", resp.ContentLength, "body_length", len(body))
 		return false
 	}
 
-	if resp.ContentLength
+	slog.Info("Healthcheck successful")
+	return true
 }

server/files/network-performance-file-generator/main_test.go

@@ -0,0 +1,20 @@
+package main
+
+import (
+	"testing"
+	"time"
+)
+
+func Test(t *testing.T) {
+	go func() {
+		if serviceErr := run(); serviceErr != nil {
+			t.Logf("service returned error: %v", serviceErr)
+		}
+	}()
+
+	time.Sleep(200 * time.Millisecond)
+
+	if !isHealthy() {
+		t.Fatal("Service is not healthy")
+	}
+}