New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Logo Support (New in 4.5) #190

Closed

JanikWeb wants to merge 3 commits into JeremyEnglert:master from JanikWeb:patch-1

JanikWeb commented Apr 13, 2016

For testing purposes I only updated the nav-offcanvas-topbar.php with the new Custom Logo support.

JanikWeb added 3 commits

April 13, 2016 14:24


          Update theme-support.php

1e6d1a0

Custom Logo support in Customizr since 4.5


          Update theme-support.php

72cd624


          Update nav-offcanvas-topbar.php

a1d1848

Display custom logo if set in customizr. If nothing is set, display site title.

Owner

JeremyEnglert commented Nov 13, 2016 •

edited

This looks great and I really want to merge it. A couple of questions/suggestions.

Would it make sense to add flexible-width to the theme support?
You created a 'joints_the_custom_logo ' function. Would it make more sense to use 'the_custom_logo()'? It appears to do the same thing, but is already built into WordPress. See this article for a good example: https://www.sitepoint.com/wordpress-custom-logo-api/#displaying-the-custom-logo

Would you like to update and resubmit? Or I can - your call!

JeremyEnglert closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment