enable language files by default (remove comment) #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress foundation encourages internationalization of themes and plugins. As JointsWP does provide language files, I see no reason, not to use them by default (as e.g. all WordPress Twenty* themes do). Even more, having it disabled by default gives a first impression of the theme not being translated (e.g. in Live Preview Mode).
|
Hi all, I second this request. I can't see any good reason for having language support commented out. |
|
This will be implemented in JointsWP 2. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WordPress foundation encourages internationalization of themes and plugins. As JointsWP does provide language files, I see no reason, not to use them by default (as e.g. all WordPress Twenty* themes do). Even more, having it disabled by default gives a first impression of the theme not being translated (e.g. in Live Preview Mode).