Fix StyleCop warnings

Jericho · Dec 6, 2016 · 0644524 · 0644524
1 parent e862834
commit 0644524
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/Source/StrongGrid/Model/Webhooks/InboundEmail.cs b/Source/StrongGrid/Model/Webhooks/InboundEmail.cs
@@ -96,7 +96,7 @@ public class InboundEmail
 		public string SpamScore { get; set; }
 
 		/// <summary>
-		/// Gets or sets the attachment. 
+		/// Gets or sets the attachment.
 		/// </summary>
 		/// <value>
 		/// The attachment.

diff --git a/Source/StrongGrid/Model/Webhooks/InboundEmailAttachment.cs b/Source/StrongGrid/Model/Webhooks/InboundEmailAttachment.cs
@@ -3,9 +3,11 @@
 
 namespace StrongGrid.Model.Webhooks
 {
+	/// <summary>
+	/// Strongly typed representation of the information sudmited by SendGrid in a 'inbound parse' webhook
+	/// </summary>
 	public class InboundEmailAttachment
 	{
-
 		/// <summary>
 		/// Gets or sets the identifier.
 		/// </summary>
@@ -23,7 +25,7 @@ public class InboundEmailAttachment
 		public string ContentType { get; set; }
 
 		/// <summary>
-		/// Gets the data.
+		/// Gets or sets the data.
 		/// </summary>
 		/// <value>
 		/// The data.

diff --git a/Source/StrongGrid/Model/Webhooks/InboundEmailEnvelope.cs b/Source/StrongGrid/Model/Webhooks/InboundEmailEnvelope.cs
@@ -20,7 +20,6 @@ public class InboundEmailEnvelope
 
 		/// <summary>
 		/// Gets or sets from, which is the return path for the message.
-
 		/// </summary>
 		/// <value>
 		/// From.

diff --git a/Source/StrongGrid/WebhookParser.cs b/Source/StrongGrid/WebhookParser.cs
@@ -1,16 +1,16 @@
 using HttpMultipartParser;
 using Microsoft.AspNetCore.Http;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
+using StrongGrid.Model;
 using StrongGrid.Model.Webhooks;
 using StrongGrid.Utilities;
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Threading.Tasks;
 using System.Linq;
-using Newtonsoft.Json.Linq;
 using System.Text;
-using StrongGrid.Model;
+using System.Threading.Tasks;
 
 namespace StrongGrid
 {
@@ -79,7 +79,7 @@ public InboundEmail ParseInboundEmailWebhook(Stream stream)
 
 			// Convert the 'headers' from a string into array of KeyValuePair
 			var rawHeaders = parser
-				.GetParameterValue("headers", "")
+				.GetParameterValue("headers", string.Empty)
 				.Split(new[] { "\r\n", "\r", "\n" }, StringSplitOptions.RemoveEmptyEntries);
 			var headers = rawHeaders
 				.Select(header =>
@@ -122,14 +122,14 @@ public InboundEmail ParseInboundEmailWebhook(Stream stream)
 			var envelope = JsonConvert.DeserializeObject<InboundEmailEnvelope>(parser.GetParameterValue("envelope", "{}"));
 
 			// Convert the 'from' from a string into a strongly typed object
-			var rawFrom = parser.GetParameterValue("from", "");
+			var rawFrom = parser.GetParameterValue("from", string.Empty);
 			var piecesFrom = rawFrom.Split(new[] { '<', '>' }, StringSplitOptions.RemoveEmptyEntries);
-			var from = new MailAddress(piecesFrom[1], piecesFrom[0].Replace("\"", "").Trim());
+			var from = new MailAddress(piecesFrom[1], piecesFrom[0].Replace("\"", string.Empty).Trim());
 
 			// Convert the 'to' from a string into a strongly typed object
-			var rawTo = parser.GetParameterValue("to", "");
+			var rawTo = parser.GetParameterValue("to", string.Empty);
 			var piecesTo = rawFrom.Split(new[] { '<', '>' }, StringSplitOptions.RemoveEmptyEntries);
-			var to = new MailAddress(piecesFrom[1], piecesFrom[0].Replace("\"", "").Trim());
+			var to = new MailAddress(piecesFrom[1], piecesFrom[0].Replace("\"", string.Empty).Trim());
 
 			// Arrange the InboundEmail
 			var inboundEmail = new InboundEmail