(GH-368) Add missing 'limit' and 'offset' parameters

Jericho · Aug 11, 2021 · 64b1b4c · 64b1b4c
1 parent c50b213
commit 64b1b4c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/Source/StrongGrid.IntegrationTests/Tests/ApiKeys.cs b/Source/StrongGrid.IntegrationTests/Tests/ApiKeys.cs
@@ -15,7 +15,7 @@ public async Task RunAsync(IBaseClient client, TextWriter log, CancellationToken
 			await log.WriteLineAsync("\n***** API KEYS *****\n").ConfigureAwait(false);
 
 			// GET ALL THE API KEYS
-			var apiKeys = await client.ApiKeys.GetAllAsync(null, cancellationToken).ConfigureAwait(false);
+			var apiKeys = await client.ApiKeys.GetAllAsync(100, 0, null, cancellationToken).ConfigureAwait(false);
 			await log.WriteLineAsync($"There are {apiKeys.Records.Length} Api Keys").ConfigureAwait(false);
 
 			// CLEANUP PREVIOUS INTEGRATION TESTS THAT MIGHT HAVE BEEN INTERRUPTED BEFORE THEY HAD TIME TO CLEANUP AFTER THEMSELVES

diff --git a/Source/StrongGrid/Resources/ApiKeys.cs b/Source/StrongGrid/Resources/ApiKeys.cs
@@ -52,6 +52,8 @@ public Task<ApiKey> GetAsync(string keyId, string onBehalfOf = null, Cancellatio
 		/// <summary>
 		/// Get all API Keys belonging to the authenticated user.
 		/// </summary>
+		/// <param name="limit">The limit.</param>
+		/// <param name="offset">The offset.</param>
 		/// <param name="onBehalfOf">The user to impersonate.</param>
 		/// <param name="cancellationToken">Cancellation token.</param>
 		/// <returns>
@@ -61,10 +63,12 @@ public Task<ApiKey> GetAsync(string keyId, string onBehalfOf = null, Cancellatio
 		/// The response does not include the permissions associated with each api key.
 		/// In order to get the permission for a given key, you need to <see cref="GetAsync(string, string, CancellationToken)">retrieve keys one at a time</see>.
 		/// </remarks>
-		public Task<PaginatedResponseWithLinks<ApiKey>> GetAllAsync(string onBehalfOf = null, CancellationToken cancellationToken = default)
+		public Task<PaginatedResponseWithLinks<ApiKey>> GetAllAsync(int limit = 50, int offset = 0, string onBehalfOf = null, CancellationToken cancellationToken = default)
 		{
 			return _client
 				.GetAsync(_endpoint)
+				.WithArgument("limit", limit)
+				.WithArgument("offset", offset)
 				.OnBehalfOf(onBehalfOf)
 				.WithCancellationToken(cancellationToken)
 				.AsPaginatedResponseWithLinks<ApiKey>("result");

diff --git a/Source/StrongGrid/Resources/IApiKeys.cs b/Source/StrongGrid/Resources/IApiKeys.cs
@@ -28,6 +28,8 @@ public interface IApiKeys
 		/// <summary>
 		/// Get all API Keys belonging to the authenticated user.
 		/// </summary>
+		/// <param name="limit">The limit.</param>
+		/// <param name="offset">The offset.</param>
 		/// <param name="onBehalfOf">The user to impersonate.</param>
 		/// <param name="cancellationToken">Cancellation token.</param>
 		/// <returns>
@@ -37,7 +39,7 @@ public interface IApiKeys
 		/// The response does not include the permissions associated with each api key.
 		/// In order to get the permission for a given key, you need to <see cref="GetAsync(string, string, CancellationToken)">retrieve keys one at a time</see>.
 		/// </remarks>
-		Task<PaginatedResponseWithLinks<ApiKey>> GetAllAsync(string onBehalfOf = null, CancellationToken cancellationToken = default);
+		Task<PaginatedResponseWithLinks<ApiKey>> GetAllAsync(int limit = 50, int offset = 0, string onBehalfOf = null, CancellationToken cancellationToken = default);
 
 		/// <summary>
 		/// Generate a new API Key.