Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Link-header paging #367

Open
11 tasks done
Jericho opened this issue Jan 23, 2021 · 1 comment
Open
11 tasks done

More Link-header paging #367

Jericho opened this issue Jan 23, 2021 · 1 comment
Assignees
Labels
Breaking Change This change causes backward compatibility issue(s)

Comments

@Jericho
Copy link
Owner

Jericho commented Jan 23, 2021

@kevinchalet recently alerted me to the fact that SendGrid includes "link" information in the response of the GlobalSuppressions.GetAllAsync which can be useful for pagination. While investigating this situation, I found out that there are other SendGrid API endpoints that also return this 'Link' information therefore it makes sense to modify StrongGrid so their corresponding methods include this information.

I asked SendGrid for their assistance figuring out the list of endpoints that return this information and I am waiting for a reply but in the mean time here is the list that I found.

  • WebHooksSetting.GetAllInboundParseWebhookSettingsAsync GET user/webhooks/parse/settings
  • Teammates.GetAllTeammatesAsync GET teammates
  • Teammates.GetAllPendingInvitationsAsync GET teammates/pending
  • SpamReports.GetAllAsync GET suppression/spam_reports
  • SenderAuthentication.GetAllLinksAsync GET whitelabel/links
  • SenderAuthentication.GetAllReverseDnsAsync GET whitelabel/ips
  • SenderAuthentication.GetAllDomainsAsync GET whitelabel/domains
  • IpAddresses.GetAllAsync GET ips
  • ApiKeys.GetAll GET api_keys
  • Blocks.GetAllAsync GET suppression/blocks
  • InvalidEmails.GetAllAsync GET suppression/invalid_emails
@Jericho Jericho self-assigned this Jan 23, 2021
@Jericho Jericho added Improvement Breaking Change This change causes backward compatibility issue(s) and removed Improvement labels Jan 23, 2021
@Jericho Jericho changed the title Link-header paging More Link-header paging Jan 23, 2021
Jericho added a commit that referenced this issue Jan 23, 2021
Jericho added a commit that referenced this issue Jan 23, 2021
Jericho added a commit that referenced this issue Jan 23, 2021
Jericho added a commit that referenced this issue Jan 23, 2021
Jericho added a commit that referenced this issue Jan 24, 2021
Jericho added a commit that referenced this issue Jan 24, 2021
Jericho added a commit that referenced this issue Jan 25, 2021
@Jericho
Copy link
Owner Author

Jericho commented Jan 25, 2021

@kevinchalet, @jsgoupil Here's a new beta release which adds the "Links" paging information to several other methods: https://www.myget.org/feed/jericho/package/nuget/StrongGrid/0.77.0-paginated-respon0070

Please note that while investigating this issue, I found out that some endpoints support 'limit' and 'offset' despite the fact that SendGrid's documentation does not mention it. I'm sure there are more than just the ones I found though. See #368

Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Aug 18, 2023
Jericho added a commit that referenced this issue Apr 12, 2024
Jericho added a commit that referenced this issue Apr 12, 2024
Jericho added a commit that referenced this issue Apr 12, 2024
Jericho added a commit that referenced this issue Apr 12, 2024
Jericho added a commit that referenced this issue Apr 12, 2024
Jericho added a commit that referenced this issue Apr 12, 2024
Jericho added a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change This change causes backward compatibility issue(s)
Projects
None yet
Development

No branches or pull requests

1 participant