Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc refactorings #6

Merged
merged 3 commits into from Nov 16, 2018
Merged

Misc refactorings #6

merged 3 commits into from Nov 16, 2018

Conversation

JeremyTCD
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #6 into master will decrease coverage by 0.81%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   86.99%   86.18%   -0.82%     
==========================================
  Files          16       16              
  Lines         423      427       +4     
  Branches       85       85              
==========================================
  Hits          368      368              
- Misses         33       37       +4     
  Partials       22       22
Impacted Files Coverage Δ
...plementations/OutOfProcess/NodeJSProcessFactory.cs 96.36% <ø> (ø) ⬆️
...ementations/OutOfProcess/Http/HttpNodeJSService.cs 83.6% <ø> (ø) ⬆️
src/NodeJS/Strings.Designer.cs 47.36% <0%> (-5.58%) ⬇️
...ntations/OutOfProcess/OutOfProcessNodeJSService.cs 84.56% <0%> (ø) ⬆️
src/NodeJS/InvocationData/InvocationException.cs 66.66% <0%> (-33.34%) ⬇️
...ementations/OutOfProcess/Http/InvocationContent.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c213afa...bdb79a7. Read the comment docs.

@JeremyTCD JeremyTCD merged commit fb66f5b into master Nov 16, 2018
@JeremyTCD JeremyTCD deleted the Misc_Refactorings branch November 16, 2018 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant